Skip to content

[ES|QL] Fetch the query columns utils#182338

Merged
stratoula merged 10 commits intoelastic:mainfrom
stratoula:esql-fetch-utils
May 6, 2024
Merged

[ES|QL] Fetch the query columns utils#182338
stratoula merged 10 commits intoelastic:mainfrom
stratoula:esql-fetch-utils

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented May 2, 2024 •
edited
Loading

Summary

Revives this #181969

To do so, I had to create a new package search-types and move the types I need there.

The Discovery team can take it from here.

Note: It also does a cleanup on the types I move, some of them were declared twice.

@stratoula stratoula mentioned this pull request May 2, 2024
Merged
@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented May 2, 2024

/ci

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v8.15.0 labels May 2, 2024
@stratoula stratoula marked this pull request as ready for review May 2, 2024 15:57
@stratoula stratoula requested review from a team as code owners May 2, 2024 15:57
@stratoula stratoula requested a review from a team May 2, 2024 15:57
@stratoula stratoula requested review from a team as code owners May 2, 2024 15:57
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 2, 2024

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula requested a review from a team as a code owner May 2, 2024 15:57
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels May 2, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 2, 2024

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@nreese
Copy link
Copy Markdown
Contributor

nreese commented May 2, 2024

Maps plugin as a function for getting ESQL columns, https://github.com/elastic/kibana/blob/main/x-pack/plugins/maps/public/classes/sources/esql_source/esql_utils.ts#L90. Should this be replaced by this utility?

weltenwort
weltenwort approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import changes in obs-ux-logs code LGTM

ymao1
ymao1 approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes LGTM. code review only

@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented May 2, 2024 •
edited
Loading

@nreese my helper doesnt have the drop_null_columns yet. I am going to do it incrementally so I will do this on a follow up PR. I want to move other utilities too

nreese
nreese approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canvas changes LGTM
code review only

nickofthyme
nickofthyme approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis changes LGTM

cauemarcondes
cauemarcondes approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PhilippeOberti
PhilippeOberti approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM for the Threat Hunting Investigations

tonyghiani
tonyghiani approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs_shared changes LGTM 👌

@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented May 3, 2024

/ci

walterra
walterra approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML related changes LGTM.

lukasolson
lukasolson approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search changes LGTM! Thanks for cleaning this up.

jaredburgettelastic
jaredburgettelastic approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaredburgettelastic jaredburgettelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entity Analytics changes LGTM!

rylnd
rylnd approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection engine changes were limited to changing the location of import declarations. LGTM!

@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented May 6, 2024

/ci

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 6, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 491 492 +1
apm 1675 1676 +1
dataVisualizer 644 645 +1
discover 796 797 +1
eventAnnotationListing 538 539 +1
infra 1466 1472 +6
lens 1414 1415 +1
lists 288 289 +1
logsExplorer 584 585 +1
maps 1185 1186 +1
ml 2014 2015 +1
observabilityAIAssistantApp 234 240 +6
securitySolution 5481 5482 +1
slo 753 754 +1
stackAlerts 145 151 +6
unifiedHistogram 138 139 +1
unifiedSearch 252 253 +1
total +32

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-utils 21 28 +7
@kbn/search-types - 25 +25
data 2621 2575 -46
total -14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +532.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB
Unknown metric groups

API count

id before after diff
@kbn/esql-utils 23 30 +7
@kbn/search-types - 50 +50
data 3290 3186 -104
total -47

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 807da63 into elastic:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

@nreese nreese nreese approved these changes

@rylnd rylnd rylnd approved these changes

@weltenwort weltenwort weltenwort approved these changes

@lukasolson lukasolson lukasolson approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@seanrathier seanrathier seanrathier approved these changes

@ymao1 ymao1 ymao1 approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@semd semd semd approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@sphilipse sphilipse sphilipse approved these changes

@jaredburgettelastic jaredburgettelastic jaredburgettelastic approved these changes

@tiansivive tiansivive Awaiting requested review from tiansivive tiansivive was automatically assigned from elastic/security-entity-analytics

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-defend-workflows

+1 more reviewer

@sebelga sebelga sebelga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

apm:review backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.