[ML] Log rate analysis EUI table fixes#181908
Merged
cee-chen merged 3 commits intoelastic:mainfrom Apr 29, 2024
Merged
Conversation
- `truncateText: true` needs to be applied now, was previously relying on old CSS that wasn't good - `textOnly` no longer needs to be passed if `truncateText` is passed so we can skip it, also it makes more sense to do so here since custom badges are being rendered
- kind of the opposite problem going on here - `textTruncate: true` now always applies an inner `__text` wrapper which messes up the flex behavior - so we need to exclude it and apply text truncation only to the actual text
Contributor
Author
|
/ci |
peteharverson
approved these changes
Apr 29, 2024
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested and LGTM. Thanks for fixing!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #181804. Follow up to #180514
Screenshots of fixed issues:
Checklist