[8.14] [Bug][Investigations] - Fix eql tab scrolling (#181763)#181874
Merged
michaelolo24 merged 2 commits intoelastic:8.14from Apr 26, 2024
Merged
[8.14] [Bug][Investigations] - Fix eql tab scrolling (#181763)#181874michaelolo24 merged 2 commits intoelastic:8.14from
michaelolo24 merged 2 commits intoelastic:8.14from
Conversation
## Summary This issue only affects 8.14. Some wrappers were added unnecessarily to the correlations tab in Timeline preventing users from scrolling in this PR: elastic#179832 This PR fixes it by placing the structure more in line with how it was prior here: https://github.com/elastic/kibana/pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe The fix: https://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd (cherry picked from commit 11eb39b) # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/eql/header/index.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.tsx
PhilippeOberti
approved these changes
Apr 26, 2024
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
desk tested and code LGTM!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.14:Questions ?
Please refer to the Backport tool documentation