Skip to content

[Fleet] Fix cancel action in log level select#181007

Merged
criamico merged 2 commits intoelastic:mainfrom
criamico:158861_fix_cancel_button
Apr 17, 2024
Merged

[Fleet] Fix cancel action in log level select#181007
criamico merged 2 commits intoelastic:mainfrom
criamico:158861_fix_cancel_button

Conversation

@criamico
Copy link
Copy Markdown
Member

@criamico criamico commented Apr 17, 2024 •
edited
Loading

Summary

Part of #158861
#180607 added a new log level selector in Agent Policy settings. However there were some small bugs with it. This PR addresses all of them:

  • Extra dot in copy text
  • A broken link was displayed - Made this link optional
  • When clicking "Cancel", all the other fields on the page reset back to their original values but the log level doesn't. The reason is the no default was set for the select

Before

image (19)

After

Screenshot 2024-04-17 at 10 50 04

Testing

  • Enable hidden: false here
  • Change the log level and then click "cancel" on the bottom of the page, it should reset back to the default value ("info" if the policy is new, the previous saved value if the policy already had this value set)
  • No extra dot and link should be visible

@criamico criamico self-assigned this Apr 17, 2024
@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 17, 2024
@ghost
Copy link
Copy Markdown

ghost commented Apr 17, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Apr 17, 2024
@criamico criamico marked this pull request as ready for review April 17, 2024 08:51
@criamico criamico requested a review from a team as a code owner April 17, 2024 08:51
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 17, 2024

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@criamico criamico enabled auto-merge (squash) April 17, 2024 09:16
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 17, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.3MB 1.3MB +77.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 05512f4 into elastic:main Apr 17, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@criamico criamico

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@criamico @elasticmachine @kibana-ci @juliaElastic @kibanamachine