Skip to content

[Security Solution][Endpoint] Refactor arguments to Response Actions Clients#179871

Merged
paul-tavares merged 5 commits intoelastic:mainfrom
paul-tavares:task/olm-refactor-use-of-connector-acitons-client
Apr 4, 2024
Merged

[Security Solution][Endpoint] Refactor arguments to Response Actions Clients#179871
paul-tavares merged 5 commits intoelastic:mainfrom
paul-tavares:task/olm-refactor-use-of-connector-acitons-client

Conversation

@paul-tavares
Copy link
Copy Markdown
Contributor

Summary

  • Refactors Response Actions Client's to be initialized using NormalizedExternalConnectorClient instead of the Action plugin ActionClient
    • Remove Proxy code implemented in prior PR

(Feedback from PR #179388)

Checklist

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0 labels Apr 2, 2024
@paul-tavares paul-tavares self-assigned this Apr 2, 2024
@paul-tavares paul-tavares requested a review from a team as a code owner April 2, 2024 19:47
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares requested review from gergoabraham and removed request for szwarckonrad April 2, 2024 19:47
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for putting effort in this refactoring, @paul-tavares ! 🙌 it looks good 🚀

@paul-tavares paul-tavares merged commit d723a1b into elastic:main Apr 4, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 4, 2024
@paul-tavares paul-tavares deleted the task/olm-refactor-use-of-connector-acitons-client branch April 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants