Skip to content

fix: [Integrations > Add integration prompt][SCREEN READER]: Images are decorative and should be removed from the accessibility tree#179805

Merged
alexwizp merged 1 commit intoelastic:mainfrom
alexwizp:#8989
Apr 2, 2024
Merged

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Apr 2, 2024 •
edited
Loading

Closes: https://github.com/elastic/security-team/issues/8989

Description

The Add integration prompt has a number of images that are decorative, but have alt text added. This could be confusing to screen reader users because the images do not provide additional context or information. Let's update them to have alt="" attributes so the images are removed from the accessibility tree. Screenshot attached below.

Steps to recreate

  1. Create a new Security Serverless project if none exist
  2. When the project is ready, open it and go to Integrations, under the Project Settings in the lower left navigation
  3. Search for DynamoDB in the Integrations, and click on the card
  4. From the DynamoDB detail view, click "Add Amazon DynamoDB"
  5. When the "Ready to add your first integration?" view loads, open Dev Tools and verify the images highlighted have alt text.

What was done?

  1. role="presentation" was set to image container
  2. removed extra alt's attributes

@alexwizp
fix: [Integrations > Add integration prompt][SCREEN READER]: Images a…
f8a0852 
…re decorative and should be removed from the accessibility tree

Closes: elastic/security-team#8989
@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0 labels Apr 2, 2024
@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Apr 2, 2024

/ci

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 2, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB -195.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review April 2, 2024 12:01
@alexwizp alexwizp requested a review from a team as a code owner April 2, 2024 12:01
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 2, 2024

Pinging @elastic/fleet (Feature:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 2, 2024

Pinging @elastic/security-solution (Team: SecuritySolution)

kpollich
kpollich approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic fix, thank you!

@alexwizp alexwizp merged commit 9e6376c into elastic:main Apr 2, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexwizp @kibana-ci @elasticmachine @kpollich @kibanamachine