Skip to content

[Serverless] validate response#179794

Merged
wayneseymour merged 3 commits intoelastic:mainfrom
wayneseymour:validate-response
Apr 2, 2024
Merged

[Serverless] validate response#179794
wayneseymour merged 3 commits intoelastic:mainfrom
wayneseymour:validate-response

Conversation

@wayneseymour
Copy link
Copy Markdown
Contributor

Summary

Assertions were failing on serverless.

So use helper methods to print out more info
in case of failure.

Assertions were failing on serverless.

So use helper methods to print out more info
in case of failure.
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.14.0 labels Apr 2, 2024
@wayneseymour wayneseymour self-assigned this Apr 2, 2024
@wayneseymour wayneseymour marked this pull request as ready for review April 2, 2024 09:18
@wayneseymour wayneseymour requested a review from a team as a code owner April 2, 2024 09:18
@wayneseymour wayneseymour requested a review from pheyos April 2, 2024 09:28
Copy link
Copy Markdown
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wayneseymour wayneseymour merged commit 61b80ca into elastic:main Apr 2, 2024
@wayneseymour wayneseymour deleted the validate-response branch April 2, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants