[Security AI Assistant] Use dictionary for replacement in APIs and convert to object in storage.#179722
Merged
YulNaumenko merged 10 commits intoelastic:mainfrom Apr 1, 2024
Conversation
…dictionary-as-replacements # Conflicts: # x-pack/plugins/elastic_assistant/server/ai_assistant_data_clients/conversations/types.ts
pmuellr
approved these changes
Apr 1, 2024
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
Looks like the only ResponseOps changes were to a function test - same changes made to a Security function test - so LGTM!
💛 Build succeeded, but was flaky
Failed CI StepsThe CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
andrew-goldstein
approved these changes
Apr 1, 2024
Contributor
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thanks for this API update @YulNaumenko! 🙏
✅ Desk tested locally
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers