Skip to content

[Security AI Assistant] Fixed connector related bugs#179589

Merged
YulNaumenko merged 7 commits intoelastic:mainfrom
YulNaumenko:security-assistant-fix-connectors-stuff
Mar 29, 2024
Merged

[Security AI Assistant] Fixed connector related bugs#179589
YulNaumenko merged 7 commits intoelastic:mainfrom
YulNaumenko:security-assistant-fix-connectors-stuff

Conversation

@YulNaumenko
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko commented Mar 28, 2024 •
edited
Loading

Fixed bugs:

  • mixing concepts of LangChain llmType and streaming actionTypeId for streaming purposes;
  • selecting inline connector didn't affect immediately settings level connector select;
  • override on change conversation connector apiConfig provider and model values when connector doesn't have it;

@YulNaumenko YulNaumenko added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Mar 28, 2024
@YulNaumenko YulNaumenko self-assigned this Mar 28, 2024
@YulNaumenko YulNaumenko requested a review from a team as a code owner March 28, 2024 00:43
@YulNaumenko YulNaumenko added the bug Fixes for quality problems that affect the customer experience label Mar 28, 2024
stephmilovic
stephmilovic approved these changes Mar 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YulNaumenko YulNaumenko enabled auto-merge (squash) March 29, 2024 20:13
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 29, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 16.6MB 16.6MB +289.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko merged commit 7b45c42 into elastic:main Mar 29, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YulNaumenko @kibana-ci @andrew-goldstein @stephmilovic @kibanamachine