Skip to content

[Fleet] Add api integration test for subfeature privileges#179574

Merged
nchaulet merged 6 commits intoelastic:mainfrom
nchaulet:feature-test-subfeature-privileges-api
Apr 2, 2024
Merged

[Fleet] Add api integration test for subfeature privileges#179574
nchaulet merged 6 commits intoelastic:mainfrom
nchaulet:feature-test-subfeature-privileges-api

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Mar 27, 2024 •
edited
Loading

Summary

Related to https://github.com/elastic/ingest-dev/issues/3063

Add api integration test for subfeature privileges

@ghost
Copy link
Copy Markdown

ghost commented Mar 27, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

nchaulet
nchaulet commented Mar 27, 2024
View reviewed changes
x-pack/test/fleet_api_integration/apis/agents/privileges.ts

let agentDoc: any;

const ROUTES = [
Copy link
Copy Markdown
Member Author

@nchaulet nchaulet Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpollich it is what you add in mind for the API integration tests? this generate tests like this for each route
Screenshot 2024-03-27 at 1 48 05 PM

Copy link
Copy Markdown
Member

@kpollich kpollich Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly this looks great!

@kpollich kpollich self-requested a review March 28, 2024 16:02
@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Mar 28, 2024

/ci

@nchaulet nchaulet marked this pull request as ready for review April 1, 2024 00:47
@nchaulet nchaulet requested review from a team as code owners April 1, 2024 00:47
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 1, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 1, 2024

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 1, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kpollich
kpollich approved these changes Apr 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@nchaulet nchaulet merged commit df92738 into elastic:main Apr 2, 2024
@nchaulet nchaulet deleted the feature-test-subfeature-privileges-api branch April 2, 2024 01:21
@kibanamachine kibanamachine added v8.14.0 backport:skip This PR does not require backporting labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

@kpollich kpollich kpollich approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nchaulet @elasticmachine @kibana-ci @jbudz @kpollich @kibanamachine