Skip to content

[8.12] [ML] Fixes Single Metric Viewer's zoom settings in URL are not restored if URL specifies a forecast ID (#176969)#177124

Merged
qn895 merged 4 commits intoelastic:8.12from
qn895:backport/8.12/pr-176969
Mar 21, 2024
Merged

[8.12] [ML] Fixes Single Metric Viewer's zoom settings in URL are not restored if URL specifies a forecast ID (#176969)#177124
qn895 merged 4 commits intoelastic:8.12from
qn895:backport/8.12/pr-176969

Conversation

@qn895
Copy link
Copy Markdown
Member

@qn895 qn895 commented Feb 16, 2024

…ed if URL specifies a forecast ID (elastic#176969)

## Summary

Fix elastic#168583

After

https://github.com/elastic/kibana/assets/43350163/9fd1f43a-ca70-4495-b872-57cbcf421db9

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 912c260)
@qn895 qn895 added the backport This PR is a backport of another PR label Feb 16, 2024
@qn895 qn895 enabled auto-merge (squash) February 16, 2024 21:36
@qn895 qn895 added the v8.12.2 label Feb 16, 2024
@qn895 qn895 self-assigned this Feb 16, 2024
@qn895
Copy link
Copy Markdown
Member Author

qn895 commented Feb 19, 2024

@elasticmachine merge upstream

@qn895
Copy link
Copy Markdown
Member Author

qn895 commented Feb 22, 2024

@elasticmachine merge upstream

@qn895 qn895 added v8.12.3 and removed v8.12.2 labels Mar 19, 2024
@qn895
Copy link
Copy Markdown
Member Author

qn895 commented Mar 19, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +12.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@qn895 qn895 merged commit 7d1cc16 into elastic:8.12 Mar 21, 2024
@qn895
Copy link
Copy Markdown
Member Author

qn895 commented Mar 21, 2024

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

ignoring request to update branch, pull request is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR v8.12.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants