[ResponseOps] add parallel number arrays to task manager metric histograms#176881
Merged
pmuellr merged 3 commits intoelastic:mainfrom Apr 1, 2024
Merged
[ResponseOps] add parallel number arrays to task manager metric histograms#176881pmuellr merged 3 commits intoelastic:mainfrom
pmuellr merged 3 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
6929e32 to
ccda136
Compare
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
9fe23ba to
0dff653
Compare
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
0dff653 to
f3697f3
Compare
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
…grams towards: elastic/response-ops-team#151 As we've found the elasticsearch histogram mapping type to be difficult to use in practice, we're switching to an "array of numbers" approach as well. We'll eventually remove the histograms, once we ensure they aren't being used.
f3697f3 to
425a808
Compare
Contributor
Author
|
/ci |
pmuellr
commented
Mar 14, 2024
| private maxValue: number; | ||
| private bucketSize: number; | ||
| private histogramBuckets: Bucket[] = []; | ||
| private allValues: number[] = []; |
Contributor
Author
There was a problem hiding this comment.
To track the actual values, we just changed the SimpleHistogram class we use to create histogram shapes, to also track each value passed in. And add getAllValues() to return it.
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
approved these changes
Mar 18, 2024
Contributor
ymao1
left a comment
There was a problem hiding this comment.
LGTM! Ran locally and was able to see the raw histogram values in /api/task_manager/metrics
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards: https://github.com/elastic/response-ops-team/issues/151
Summary
As we've found the elasticsearch histogram mapping type to be difficult to use in practice, we're switching to an "array of numbers" approach - keeping the histograms for now. We'll eventually remove the histograms, once we ensure they aren't being used.