Skip to content

chore(NA): upgrade typescript into v4.9.5#175178

Merged
mistic merged 35 commits intoelastic:mainfrom
mistic:upgrade-typescript-v4-9-5
Feb 25, 2024
Merged

chore(NA): upgrade typescript into v4.9.5#175178
mistic merged 35 commits intoelastic:mainfrom
mistic:upgrade-typescript-v4-9-5

Conversation

@mistic
Copy link
Copy Markdown
Contributor

@mistic mistic commented Jan 20, 2024 •
edited by banderror
Loading

This PR bumps the Typescript version used on Kibana into v4.9.5. The full set of changes can be found here. So far, as long I can see, the performance is better than in the version we're currently in.

I didn't want to make assumptions for such a diversity of type errors across the codebase so instead I choose to mark the failures with @ts-expect-error and let each team decide how to handle it.

There is a list below with the files (and teams those belong to) where the annotations were added. If each team could provide help of fixing the ones under their domain it would be fantastic. It can be done in this PR or in subsequent ones.

Here it goes the list for follow up:

@elastic/kibana-core - tracking issue: #176153

@elastic/kibana-presentation

@elastic/apm

@elastic/obs-knowledge-team

@elastic/security-detection-engine

@elastic/appex-sharedux

@elastic/kibana-visualizations

@elastic/kibana-data-discovery

@elastic/platform-deployment-management

@elastic/kibana-security

@elastic/ml-ui

@elastic/response-ops

@elastic/security-threat-hunting-investigations

@elastic/security-generative-ai

@elastic/enterprise-search-frontend

@elastic/fleet

@elastic/platform-deployment-management

@elastic/obs-ux-logs-team / @elastic/obs-ux-infra_services-team

@elastic/kibana-gis

@elastic/observability-ui

@elastic/security-defend-workflows

@elastic/security-solution

@elastic elastic deleted a comment from kibana-ci Jan 20, 2024
@elastic elastic deleted a comment from kibana-ci Jan 20, 2024
@elastic elastic deleted a comment from kibana-ci Jan 20, 2024
@elastic elastic deleted a comment from kibana-ci Jan 21, 2024
@mistic mistic changed the title chore(NA): upgrade typescript into v4 9 5 chore(NA): upgrade typescript into v4.9.5 Jan 21, 2024
@mistic mistic added chore Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.13.0 labels Feb 1, 2024
@mistic mistic marked this pull request as ready for review February 1, 2024 18:12
@mistic mistic requested review from a team and dgieselaar as code owners February 1, 2024 18:12
achyutjhunjhunwala
achyutjhunjhunwala approved these changes Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Logs UX side

@achyutjhunjhunwala achyutjhunjhunwala mentioned this pull request Feb 13, 2024
Closed
2 tasks
justinkambic
justinkambic reviewed Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistic I have pushed 48bd988 to this branch to correct most of the errors in the Synthetics/UX plugin directories. I haven't approved because I want to let maintainers of the apm/infra plugins on my team evaluate if they want to merge any fixes as well.

Don't hesitate to ping me if there are any issues related to my changes. Thanks for the upgrade.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 23, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 24, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console Host Isolation: should isolate a host from response console should isolate a host from response console

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionLegacyMetricVis 11.9KB 11.9KB -10.0B
visTypeTimeseries 514.3KB 514.3KB +8.0B
total -2.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observabilityShared 19 20 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented Feb 25, 2024

I've went ahead and merged this one. The missing places with a ts-expect-error to be fixed can be found in the description of the PR. Please let me know if you have any other feedback.

@kibanamachine kibanamachine mentioned this pull request Mar 4, 2024
Merged
@delanni
Copy link
Copy Markdown
Member

delanni commented Mar 6, 2024

Cross-referencing #160033 for discoverability

@tonyghiani tonyghiani mentioned this pull request Mar 6, 2024
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 22, 2024
Merged
Merged
@walterra walterra mentioned this pull request Nov 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janmonschke janmonschke janmonschke left review comments

@justinkambic justinkambic justinkambic left review comments

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@achyutjhunjhunwala achyutjhunjhunwala achyutjhunjhunwala approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@azasypkin azasypkin azasypkin approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@nreese nreese nreese approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@banderror banderror banderror approved these changes

@lukasolson lukasolson lukasolson approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@walterra walterra walterra approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@sphilipse sphilipse sphilipse approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

@tiansivive tiansivive Awaiting requested review from tiansivive tiansivive was automatically assigned from elastic/security-entity-analytics

@paul-tavares paul-tavares Awaiting requested review from paul-tavares paul-tavares was automatically assigned from elastic/security-defend-workflows

+3 more reviewers

@wayneseymour wayneseymour wayneseymour approved these changes

@WafaaNasr WafaaNasr WafaaNasr approved these changes

@rshen91 rshen91 rshen91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting chore Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. Team:Operations Kibana-Operations Team v8.13.0 v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.