Skip to content

[Index Management] Add index name badges to the details page#170558

Merged
yuliacech merged 5 commits intoelastic:mainfrom
yuliacech:im/details_page/fix_badges
Nov 7, 2023
Merged

[Index Management] Add index name badges to the details page#170558
yuliacech merged 5 commits intoelastic:mainfrom
yuliacech:im/details_page/fix_badges

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech commented Nov 3, 2023 •
edited
Loading

Summary

Fixes #170335

This PR adds index name badges to the index details page. The badges used to be rendered in the index details flyout but were not re-implemented for the new details page in #165705.
Currently, there are only 3 possible badges: "frozen", "rollup" and "follower".

Screenshots

Short index name

Screenshot 2023-11-03 at 17 53 18

Long index name

Screen.Recording.2023-11-02.at.19.14.05.mov

Checklist

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Nov 3, 2023
@yuliacech yuliacech marked this pull request as ready for review November 3, 2023 17:13
@yuliacech yuliacech requested a review from a team as a code owner November 3, 2023 17:13
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 3, 2023

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Nov 3, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 576.0KB 576.1KB +83.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
rollup 11.9KB 11.9KB +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ElenaStoeva ElenaStoeva self-requested a review November 6, 2023 14:34
ElenaStoeva
ElenaStoeva approved these changes Nov 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this enhancement @yuliacech! Tested the badges locally and code changes LGTM. 👍

@yuliacech yuliacech added this pull request to the merge queue Nov 7, 2023
Merged via the queue into elastic:main with commit cecd175 Nov 7, 2023
@yuliacech yuliacech deleted the im/details_page/fix_badges branch November 7, 2023 12:21
@kibanamachine kibanamachine added v8.12.0 backport:skip This PR does not require backporting labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Index Management] Index details page should render badges in the index name

5 participants

@yuliacech @elasticmachine @kibana-ci @ElenaStoeva @kibanamachine