Upgrade EUI to v90.0.0 by cee-chen · Pull Request #170179 · elastic/kibana

cee-chen · 2023-10-30T19:50:50Z

v89.1.0⏩v90.0.0

The majority of changes in this PR come from:

EuiContextMenu being converted to Emotion ([Emotion] Convert EuiContextMenu, EuiContextMenuPanel, and EuiContextMenuItem eui#7312). If your usage of EuiContextMenu was significantly affected, we recommend pulling down this PR and QAing it locally.
defaultProps being removed from some very widespread components, particularly EuiButton, in anticipation of React's upcoming deprecation. (elastic/eui@b7dc9b4) NOTE: This only affected Enzyme snapshots, and did not affect production behavior.

Commits have been broken up by component changes as well as types of changes.

`90.0.0`

Updated the eventColor prop on EuiCommentEvent to apply the color to the entire comment header. (#7288)
Updated EuiBasicTable and EuiInMemoryTable to support a new controlled selection API: selection.selected (#7321)

Bug fixes

Fixed controlled EuiFieldNumbers not correctly updating native validity state (#7291)
Fixed EuiListGroupItem to pass style props to the wrapping <li> element alongside className and css. All other props will be passed to the underlying content. (#7298)
Fixed EuiListGroupItem's non-transitioned transform on hover/focus (#7298)
Fixed EuiDataGrids with gridStyle.stripes sometimes showing buggy row striping after being sorted (#7301)
Fixed EuiDataGrid's gridStyle.rowClasses API to not conflict with gridStyle.stripes if dynamically updated (#7301)
Fixed EuiDataGrid's gridStyle.rowClasses API to support multiple space-separated classes (#7301)
Fixed EuiInputPopover not calling onPanelResize callback prop (#7305)
Fixed EuiDualRange incorrectly positioning highlights when rendered with showInput="inputWithPopover" (#7305)
Fixed EuiTabs incorrectly wrapping text when it should instead either scroll or truncate (#7309)
EuiContextMenu now renders text colors correctly when used within an EuiBottomBar (#7312)
Fixed the width of EuiSuperDatePicker's Absolute date picker (#7313)
Fixed EuiDataGrid cells visually cutting off overflowing content a little too quickly (#7320)

Deprecations

Deprecated EuiBasicTable and EuiInMemoryTable's ref setSelection API. Use the new selection.selected API instead. (#7321)

Breaking changes

Removed EuiPageTemplate_Deprecated, EuiPageSideBar_Deprecated, and EuiPageContent*_Deprecated (#7265)
Removed the ghost color option from EuiButton, EuiButtonEmpty, and EuiButtonIcon. Use an <EuiThemeProvider colorMode="dark"> wrapper and color="text" instead. (#7296)

Dependency updates

Updated refractor to v3.6.0 (#7127)
Updated rehype-raw to v5.1.0 (#7127)
Updated vfile to v4.2.1 (#7127)

Accessibility

EuiContextMenu now correctly respects reduced motion preferences (#7312)
EuiAccordions no longer attempt to focus child content when the accordion is externally opened via forceState, but will continue to focus expanded content when users click the toggle button. (#7314)

CSS-in-JS conversions

Converted EuiContextMenu, EuiContextMenuPanel, and EuiContextMenuItem to Emotion; Removed $euiContextMenuWidth (#7312)

cee-chen · 2023-10-30T20:01:44Z

@elasticmachine merge upstream

- should now be handled OOTB by EUI 7288

- to use the component directly, and import the specific styles required

- extra specificity needed due to Emotion conversion + Enzyme

…r Emotion conversion - index increase is due to the fact that the title now reuses `EuiContextMenuItem` under the hood as well

- affected by Emotion conversion

…on query update bug

cee-chen · 2023-10-31T21:37:26Z

x-pack/plugins/security_solution/public/assistant/get_comments/index.tsx

-            `,
-          }
-        : {}),
+      eventColor: message.isError ? 'danger' : undefined,


@stephmilovic FYI that EuiCommentEvent respecting eventColor for all types is now fixed in EUI, and the workaround you added in #167674 should no longer be necessary - but please feel free to QA and let us know if that's not the case!

amazing, thank you!!

Ikuni17

OPs changes lgtm

davismcphee

Data Discovery changes LGTM. Tested the Unified Field List style change and it's working as expected 👍

afharo

LGTM

justinkambic

LGTM!!

dej611

Tested Lens and could not find an issue 👍

cnasikas

ResponseOps changes LGTM!

peteharverson

ML changes LGTM

jeramysoucy

Kibana Security changes LGTM!

nickpeihl

Canvas shareable runtime changes lgtm!

I did not review Maps changes since @nreese is doing that.

nreese

maps changes LGTM
code review, tested in chrome

1Copenut

👍 EUI team looks good!

mashhurs

Logstash pipeline related changes LGTM!

maximpn

Rule Management Area LGTM

stephmilovic

LGTM for explore changes, thanks for the updates!

kibana-ci · 2023-11-03T17:19:32Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 3fde6ef

Failed CI Steps

FTR Configs #5

Test Failures

[job] [logs] FTR Configs #5 / visualize app annotation listing page edit individual annotations edits an existing annotation

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1505	1506	+1
`console`	200	201	+1
`infra`	1333	1334	+1
`maps`	930	1062	+132
`observability`	489	490	+1
`securitySolution`	4656	4657	+1
`triggersActionsUi`	599	600	+1
`urlForwarding`	8	9	+1
total			+139

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`@kbn/user-profile-components`	0	1	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.7MB	3.7MB	+2.4KB
`discover`	587.2KB	587.2KB	-22.0B
`eventAnnotationListing`	197.9KB	197.9KB	+46.0B
`infra`	1.9MB	1.9MB	+2.4KB
`lens`	1.4MB	1.4MB	+24.0B
`maps`	2.7MB	2.9MB	+171.6KB
`observability`	1.1MB	1.1MB	+2.4KB
`securitySolution`	12.9MB	12.9MB	+2.0KB
`triggersActionsUi`	1.4MB	1.4MB	+2.4KB
total			+183.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`console`	26.8KB	29.2KB	+2.4KB
`core`	372.0KB	372.3KB	+279.0B
`kbnUiSharedDeps-css`	263.8KB	256.1KB	-7.7KB
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	-5.2KB
`maps`	46.6KB	46.7KB	+58.0B
`urlForwarding`	2.6KB	5.0KB	+2.4KB
total			-7.7KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/visualization-ui-components`	0	1	+1

Total ESLint disabled count

id	before	after	diff
`@kbn/visualization-ui-components`	0	1	+1

History

💚 Build #172376 succeeded 0657a08
💔 Build #172366 failed e49ba60fbb57750e56d033eca7e2e27986ece5bc
💔 Build #172107 failed 441d6187a665fb281938064bc25f13f29cc9c4f1
💔 Build #172104 failed 5ad970d3c0caffdd7fe07a92f969e7c4be96da22
💔 Build #172094 failed f02835099e4b1611c19dc17958cd793b190ae728
💔 Build #172046 failed 51e2f9ad0c366b81d06ea76eead0d5a28539957c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.12.0 labels Oct 30, 2023

cee-chen force-pushed the eui-v90.x branch 3 times, most recently from 5ad970d to 441d618 Compare October 31, 2023 04:19

cee-chen added 11 commits October 31, 2023 12:26

Upgrade EUI to v90.0.0

5def5b3

i18n changes

33d07d6

.defaultProps removal - Enzyme snapshot updates

6799576

[EuiInputPopover] Update type

a261319

[EuiCommentEvent] Remove now-unnecessary color override

34da769

- should now be handled OOTB by EUI 7288

[EuiCommentEvent] Snapshot updates

bc79ffc

[EuiContextMenuPanel] Update className

adce17a

[EuiContextMenu] Remove now unnecessary CSS specificity

9528498

Fix static usage of EuiContextMenu CSS/DOM

f1d3bde

- to use the component directly, and import the specific styles required

[EuiContextMenu] Fix test DOM failures

e5e6c46

- extra specificity needed due to Emotion conversion + Enzyme

[EuiContextMenu][canvas shareable runtime] Update tests to account fo…

20d3666

…r Emotion conversion - index increase is due to the fact that the title now reuses `EuiContextMenuItem` under the hood as well

cee-chen force-pushed the eui-v90.x branch from 441d618 to e49ba60 Compare October 31, 2023 19:26

cee-chen mentioned this pull request Oct 31, 2023

[Lens] assist EUI with bug investigation to get to version 77.2.0 #155890

Closed

cee-chen added 4 commits October 31, 2023 13:22

[EuiContextMenuPanel] Update snapshots

e9dc927

- affected by Emotion conversion

[EuiContextMenu] Test workaround for animating/transitioning panels

4f211ca

[EuiContextMenu] Update FTR/E2E selectors

f4c7ac4

[Lens] Workaround for EuiFieldNumber validity change causing annotati…

0657a08

…on query update bug

cee-chen force-pushed the eui-v90.x branch from e49ba60 to 0657a08 Compare October 31, 2023 20:22

cee-chen commented Oct 31, 2023

View reviewed changes

cee-chen marked this pull request as ready for review October 31, 2023 21:45

cee-chen requested review from a team as code owners October 31, 2023 21:45

cee-chen requested a review from a team as a code owner October 31, 2023 21:45

cee-chen requested review from dhurley14 and maximpn October 31, 2023 21:45

Ikuni17 approved these changes Oct 31, 2023

View reviewed changes

davismcphee approved these changes Oct 31, 2023

View reviewed changes

afharo approved these changes Oct 31, 2023

View reviewed changes

justinkambic approved these changes Nov 1, 2023

View reviewed changes

dej611 approved these changes Nov 1, 2023

View reviewed changes

cnasikas approved these changes Nov 1, 2023

View reviewed changes

peteharverson approved these changes Nov 1, 2023

View reviewed changes

sabarasaba approved these changes Nov 1, 2023

View reviewed changes

xcrzx mentioned this pull request Nov 1, 2023

[Security Solution] Migrate the rule management table to controlled table selection state API #170303

Open

jeramysoucy approved these changes Nov 1, 2023

View reviewed changes

rshen91 approved these changes Nov 1, 2023

View reviewed changes

nickpeihl approved these changes Nov 1, 2023

View reviewed changes

dhurley14 approved these changes Nov 1, 2023

View reviewed changes

Dosant approved these changes Nov 1, 2023

View reviewed changes

nreese approved these changes Nov 1, 2023

View reviewed changes

neptunian approved these changes Nov 1, 2023

View reviewed changes

1Copenut approved these changes Nov 1, 2023

View reviewed changes

vadimkibana approved these changes Nov 2, 2023

View reviewed changes

mashhurs approved these changes Nov 3, 2023

View reviewed changes

maximpn approved these changes Nov 3, 2023

View reviewed changes

stephmilovic approved these changes Nov 3, 2023

View reviewed changes

Merge branch 'main' into eui-v90.x

3fde6ef

cee-chen enabled auto-merge (squash) November 3, 2023 15:51

cee-chen merged commit d079e95 into elastic:main Nov 3, 2023

cee-chen deleted the eui-v90.x branch November 3, 2023 17:19

kibanamachine added the backport:skip This PR does not require backporting label Nov 3, 2023

Conversation

cee-chen commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

90.0.0

Uh oh!

cee-chen commented Oct 30, 2023

Uh oh!

cee-chen Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

stephmilovic Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

Ikuni17 left a comment

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

dej611 left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

jeramysoucy left a comment

Choose a reason for hiding this comment

Uh oh!

nickpeihl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

1Copenut left a comment

Choose a reason for hiding this comment

Uh oh!

mashhurs left a comment

Choose a reason for hiding this comment

Uh oh!

maximpn left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Nov 3, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Any counts in public APIs

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

cee-chen commented Oct 30, 2023 •

edited

Loading

`90.0.0`

nickpeihl left a comment •

edited

Loading