Try to revert classic migrations integration tests until before flakiness#170023
Merged
Try to revert classic migrations integration tests until before flakiness#170023
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Oct 27, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @rudolf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at understanding #166190
I first thought the flakiness could be a regression in Elasticsearch, but it turns out because I can only reproduce 90% of the time I got "lucky" and found a previous ES commit where tests passed 3 times in a row. On further investigation I was able to reproduce failures on commits as old as July (before we even saw these failures) so ES is unlikely to be the root cause 👎
Looking at our flaky test failure logs I found the first occurence happened on 5 September on the branch for #164959 (before it was merged) and then subsequent failures on other branches and main happened within a few hours after #164959 was merged on 11 September.
However, nothing in #164959 should have changed or impacted behaviour. To try to track down the cause this PR is attempting to restorte
actions.test.tsuntil before #164959. Serverless tests will continue to useactions_test_suite.tsbut for classic we'll run the oldactions.test.ts.