[Infra UI] Removed unused saved object attribute and unused source configuration code#169430
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
28c9187 to
a7997ec
Compare
There was a problem hiding this comment.
this function looked for sources field in the kibana infra config and returned it as part of source configuration. It merges it with "default configuration". we can remove this function and just get the default configuration since we aren't using sources from config in our source configuration anymore.
1f6040e to
db33848
Compare
| }); | ||
| }); | ||
|
|
||
| test('adds missing attributes from the static configuration to a source configuration', async () => { |
There was a problem hiding this comment.
this is testing for kibana config values in sources field, which is no longer supported as part of source configuration. I assume at some point in the past metricAlias and logsIndices was able to be set in the kibana config from looking at this test. Under xpack.infra.sources.default.metricAlias, etc.
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
crespocarlos
left a comment
There was a problem hiding this comment.
Looks good.
I tested it against a clean local ES cluster, and the fields.message attribute is gone.
However, I still see it on my oblt-cli cluster, even after saving the infra settings form.
Is this also supposed to remove it from existent saved objects too?
|
@crespocarlos Thanks. You're correct and I updated the testing instructions to expect it to still exist if it already existed on the saved object. I am thinking to not bother removing it and new objects created will no longer have it. |
Resolves #168240
Changes
fields.messagefrom theinfrastructure-ui-sourcesaved object who's value was being populated byxpack.infra.sources.default.fields.messagefrom config. See https://www.elastic.co/guide/en/kibana/master/logs-ui-settings-kb.htmlgetInternalSourceConfigurationanddefineInternalSourceConfigurationfunctions introduced in [Logs UI] Allow for plugins to inject internal source configurations #36066 as I cannot see them being used anywhere. Stops exposingdefineInternalSourceConfigurationas part of server plugin interface.getStaticDefaultSourceConfigurationfrom InfraSources class as we aren't usingsourcesfrom kibana config in source configuration anymore.getAllSourceConfigurationsused only in removed deprecations file f427278#diff-081721894fc437938eb652beae0a0640ddeee532ec5e48af1f3093c8074f1eecL195getAllSavedSourceConfigurationsonly used ingetAllSourceConfigurationsHow to test
infrastructure-ui-sourcesaved object no longer hasfieldsattributesxpack.infra.sources.default.fields.message: ['testmessage', '@testmessage']infrastructure-ui-sourcesaved object and nofieldsattribute should exist (unless it previously existed in an already existinginfrastructure-ui-sourcesaved objectfields.messageis used in logs_shared pluginxpack.infra.sources.default.fields.message) and never uses the saved object field being removed.