[Shared UX] Remove color="ghost" on EuiBottomBar children#169307
Merged
cee-chen merged 6 commits intoelastic:mainfrom Oct 25, 2023
Merged
[Shared UX] Remove color="ghost" on EuiBottomBar children#169307cee-chen merged 6 commits intoelastic:mainfrom
color="ghost" on EuiBottomBar children#169307cee-chen merged 6 commits intoelastic:mainfrom
Conversation
- EuiBottomBar now sets a dark color mode on all children, so these colors are no longer necessary to specify
- EuiBottomBar now sets a dark color mode on all children, so these colors are no longer necessary to specify
- EuiBottomBar now sets a dark color mode on all children, so these colors are no longer necessary to specify
11 tasks
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/eui-team (EUI) |
ElenaStoeva
approved these changes
Oct 23, 2023
Contributor
ElenaStoeva
left a comment
There was a problem hiding this comment.
Tested locally in light and dark mode - LGTM.
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Contributor
Author
|
Thanks y'all!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
👋 Hey y'all - EUI will shortly be deprecating the
ghostcolor in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode).In this PR, all components using
color="ghost"are being used within anEuiBottomBarand as such already automatically inherit dark mode coloring.I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result.
Checklist