[Session View] Remove color="ghost" buttons#169305
Merged
cee-chen merged 3 commits intoelastic:mainfrom Oct 24, 2023
Merged
Conversation
11 tasks
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/eui-team (EUI) |
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
approved these changes
Oct 23, 2023
Contributor
opauloh
left a comment
There was a problem hiding this comment.
LGTM! it works as expected on both Light and Dark themes ✅
Contributor
Author
|
Thanks a million for testing @opauloh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
👋 Hey y'all - EUI will shortly be deprecating the
ghostcolor in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode).I'm opening this PR ahead of time for your team so you can test this migration and ensure no regressions have occurred as a result.
While I'm confident in the theory of the changes, I'm not totally sure how to get to this actual terminal UI to test that the changes look good in-browser - I'd appreciate your team's help QAing!
Checklist