Merged
Conversation
- which reduces the amount of default prefixes Emotion outputs
- to account for cell DOM refactored in elastic/eui#7255
- to account for updated DOM
`.getBySel` already appears to include `[data-test-subj=]` in it, so the query is broken
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Oct 18, 2023
tomsonpl
approved these changes
Oct 18, 2023
Contributor
tomsonpl
left a comment
There was a problem hiding this comment.
Defend Workflows changes LGTM 👍
thomheymann
approved these changes
Oct 18, 2023
Contributor
thomheymann
left a comment
There was a problem hiding this comment.
Security changes LGTM
maxcold
approved these changes
Oct 18, 2023
Contributor
maxcold
left a comment
There was a problem hiding this comment.
cloud_securty_posture changes LGTM
kqualters-elastic
approved these changes
Oct 19, 2023
janmonschke
approved these changes
Oct 19, 2023
MichaelMarcialis
approved these changes
Oct 19, 2023
Contributor
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Code review only. LGTM.
Contributor
Author
|
Thanks all! As always, feel free to ping us anytime if you find any regressions or issues that you think was caused by this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v89.0.0⏩v89.1.0This upgrade also contains an EuiDataGrid refactor (elastic/eui#7255) not listed in the changelog (as no end-user functionality or props changed as a result of the refactor). The unlisted changes should only affect DOM and
classNameusages in Kibana (primarily CSS overrides and test selectors).89.1.0tokenVectorSparsetoken and updatedtokenDenseVectortoken (now namedtokenVectorDense). (#7282)CSS-in-JS conversions
EuiProvider. (#7272)