Skip to content

[Index Management] Remove old code#168885

Merged
yuliacech merged 5 commits intoelastic:mainfrom
yuliacech:im/details_page/remove_code
Oct 18, 2023
Merged

[Index Management] Remove old code#168885
yuliacech merged 5 commits intoelastic:mainfrom
yuliacech:im/details_page/remove_code

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech commented Oct 13, 2023 •
edited
Loading

Summary

This PR removes some leftover code from deleting the index details flyout in #165705

@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Oct 13, 2023
@yuliacech yuliacech marked this pull request as ready for review October 16, 2023 17:52
@yuliacech yuliacech requested a review from a team as a code owner October 16, 2023 17:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 16, 2023

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech requested a review from ElenaStoeva October 16, 2023 18:47
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 16, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #5 / Timeline search and filters Update kqlMode for timeline should be able to update timeline kqlMode with filter should be able to update timeline kqlMode with filter

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 589 588 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 561.2KB 561.2KB -10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ElenaStoeva
ElenaStoeva approved these changes Oct 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuliacech for cleaning up this code! LGTM 👍

@yuliacech yuliacech merged commit c58238d into elastic:main Oct 18, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This PR does not require backporting labels Oct 18, 2023
@yuliacech yuliacech deleted the im/details_page/remove_code branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuliacech @elasticmachine @kibana-ci @ElenaStoeva @kibanamachine