Skip to content

[PoC] Add resize support to Discover doc viewer#168392

Closed
davismcphee wants to merge 1 commit intoelastic:mainfrom
davismcphee:poc-resizable-doc-viewer
Closed

[PoC] Add resize support to Discover doc viewer#168392
davismcphee wants to merge 1 commit intoelastic:mainfrom
davismcphee:poc-resizable-doc-viewer

Conversation

@davismcphee
Copy link
Copy Markdown
Contributor

Summary

WIP.

Checklist

For maintainers

@davismcphee davismcphee added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Oct 9, 2023
@davismcphee davismcphee self-assigned this Oct 9, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 9, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #65 / context app context link in discover should open the context view with the selected document as anchor and allows selecting next anchor
  • [job] [logs] FTR Configs #65 / context app context link in discover should open the context view with the selected document as anchor and allows selecting next anchor
  • [job] [logs] Jest Tests #2 / Discover flyout allows navigating with arrow keys through documents
  • [job] [logs] Jest Tests #2 / Discover flyout allows you to navigate to the next doc, if expanded doc is the first
  • [job] [logs] Jest Tests #2 / Discover flyout allows you to navigate to the previous doc, if expanded doc is the last
  • [job] [logs] Jest Tests #2 / Discover flyout displays no document navigation when the expanded doc is not part of the given docs
  • [job] [logs] Jest Tests #2 / Discover flyout displays no document navigation when there are 0 docs available
  • [job] [logs] FTR Configs #19 / discover/group2 discover data grid row navigation should navigate through rows with the same id but different indices correctly
  • [job] [logs] FTR Configs #19 / discover/group2 discover data grid row navigation should navigate through rows with the same id but different indices correctly
  • [job] [logs] Jest Tests #20 / Panels resizable should maintain the minimum sizes of both panels when the container is too small to fit them
  • [job] [logs] Jest Tests #20 / Panels resizable should maintain the size of the fixed panel and resize the flex panel when the container size changes
  • [job] [logs] Jest Tests #20 / Panels resizable should render both panels
  • [job] [logs] Jest Tests #20 / Panels resizable should resize the fixed panel once the flex panel is at its minimum size
  • [job] [logs] Jest Tests #20 / Panels resizable should set the correct sizes of both panels when the panels are resized
  • [job] [logs] Jest Tests #20 / Panels resizable should set the initial sizes of both panels
  • [job] [logs] Jest Tests #20 / Panels resizable should use containerHeight when direction is ResizableLayoutDirection.Vertical
  • [job] [logs] Jest Tests #20 / Panels resizable should use containerWidth when direction is ResizableLayoutDirection.Horizontal
  • [job] [logs] Jest Tests #20 / Panels static should render both panels when hideFixedPanel is false

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 675 678 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 398.8KB 398.8KB +12.0B
discover 573.7KB 583.4KB +9.7KB
unifiedHistogram 50.1KB 50.4KB +273.0B
total +9.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee deleted the poc-resizable-doc-viewer branch July 16, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants