[Actions] Expose getAllSystemActions from the actions client#167783
Merged
cnasikas merged 4 commits intoelastic:system_actions_mvpfrom Oct 3, 2023
Merged
[Actions] Expose getAllSystemActions from the actions client#167783cnasikas merged 4 commits intoelastic:system_actions_mvpfrom
getAllSystemActions from the actions client#167783cnasikas merged 4 commits intoelastic:system_actions_mvpfrom
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Member
Author
|
@elasticmachine merge upstream |
ersin-erdal
reviewed
Oct 2, 2023
| /** | ||
| * Get all system connectors | ||
| */ | ||
| public async getAllSystemActions(): Promise<FindConnectorResult[]> { |
Contributor
There was a problem hiding this comment.
I think the things this method returns are connectors.
Should this be getAllSystemConnectors or getAllSystemActionConnectors ?
Member
Author
There was a problem hiding this comment.
You are right! My brain is wired to the old terminology.
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposed the
getAllSystemActionsfrom the actions client. It will return all registered system actions. This functionality is needed by the rules client to determine if an action is a system action based on the connector ID.Checklist
Delete any items that are not applicable to this PR.
For maintainers