Skip to content

[ML] Trained models: Functional tests #167697

Merged
alvarezmelissa87 merged 2 commits intoelastic:mainfrom
alvarezmelissa87:ml-fix-deploy-model-test
Oct 2, 2023
Merged

[ML] Trained models: Functional tests #167697
alvarezmelissa87 merged 2 commits intoelastic:mainfrom
alvarezmelissa87:ml-fix-deploy-model-test

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 29, 2023 •
edited
Loading

Summary

Fixes #165083
Fixes #165084

This PR

  • ensures that the input for field map is empty before adding the edited value
  • removes source index requirement for review and create step as that is not available in the test environment model

flaky test runner build https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3267

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner September 29, 2023 19:52
@alvarezmelissa87 alvarezmelissa87 self-assigned this Sep 29, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2023

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added the release_note:skip Skip the PR/issue when compiling release notes label Sep 29, 2023
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 29, 2023
Closed
9 tasks
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 29, 2023

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

jgowdyelastic
jgowdyelastic approved these changes Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit ede8d61 into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 2, 2023
@alvarezmelissa87 alvarezmelissa87 deleted the ml-fix-deploy-model-test branch October 2, 2023 14:34
@peteharverson peteharverson mentioned this pull request Oct 6, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment