[Defend Workflows][Fleet] Hide uninstall token for Cloud Agent Policy#167627
Merged
dasansol92 merged 1 commit intoelastic:mainfrom Oct 2, 2023
Merged
Conversation
💚 Build Succeeded
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
joeypoon
approved these changes
Sep 29, 2023
juliaElastic
reviewed
Oct 2, 2023
| field: `${UNINSTALL_TOKENS_SAVED_OBJECT_TYPE}.attributes.policy_id`, | ||
| size: bucketSize, | ||
| include, | ||
| exclude: 'policy-elastic-agent-on-cloud', // todo: find a better way to not return or even generate token for managed policies |
Contributor
There was a problem hiding this comment.
Can we add a test for this?
Contributor
Author
There was a problem hiding this comment.
will do in a follow-up pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #164013
The API does not return uninstall token for the policy id
policy-elastic-agent-on-cloudquestions
managedpolicies, too?managedpolicies at all?