Skip to content

[ML] Data frame analytics: ensures destination index setting is persisted when cloning#167584

Merged
alvarezmelissa87 merged 2 commits intoelastic:mainfrom
alvarezmelissa87:ml-dfa-dest-index-clone-fix
Oct 2, 2023
Merged

[ML] Data frame analytics: ensures destination index setting is persisted when cloning#167584
alvarezmelissa87 merged 2 commits intoelastic:mainfrom
alvarezmelissa87:ml-dfa-dest-index-clone-fix

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 28, 2023 •
edited
Loading

Summary

Fixes #164696

This PR ensures that the Destination index same as job ID state is persisted when switching between steps for original jobs and cloned jobs.

DFAdestIndexFix.mp4

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner September 28, 2023 23:59
@alvarezmelissa87 alvarezmelissa87 self-assigned this Sep 28, 2023
@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 28, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 28, 2023

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added the Feature:Data Frame Analytics ML data frame analytics features label Sep 28, 2023
@peteharverson peteharverson changed the title [ML] Data frame analytics: ensure destination index setting is persisted [ML] Data frame analytics: ensures destination index setting is persisted when cloning Sep 29, 2023
peteharverson
peteharverson approved these changes Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Copy Markdown
Member

qn895 commented Sep 29, 2023

Code LGTM 🎉

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 29, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -33.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 267328b into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 2, 2023
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-dest-index-clone-fix branch October 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels

backport:skip This PR does not require backporting Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ML] Data frame analytics: Destination index setting is not remembered when cloning a job

6 participants

@alvarezmelissa87 @elasticmachine @qn895 @kibana-ci @peteharverson @kibanamachine