Skip to content

[Profiling] New Profiling ES Flamegraph API#167477

Merged
cauemarcondes merged 17 commits intoelastic:mainfrom
cauemarcondes:profiling-new-ES-flamegraph-api
Oct 2, 2023
Merged

[Profiling] New Profiling ES Flamegraph API#167477
cauemarcondes merged 17 commits intoelastic:mainfrom
cauemarcondes:profiling-new-ES-flamegraph-api

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Sep 28, 2023 •
edited
Loading

New setting was added to go back to use the old one:
Screenshot 2023-09-28 at 10 03 08

In the old API, some logic was still being handled by kibana to create the flamegraph data. This logic was moved to the Profiling ES plugin and a new API was created: _profiling/flamegraph. We've proven that this has improved the loading time to render the profiling in ~3s.

@ghost
Copy link
Copy Markdown

ghost commented Sep 28, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes marked this pull request as ready for review September 28, 2023 09:07
@cauemarcondes cauemarcondes requested review from a team as code owners September 28, 2023 09:07
@cauemarcondes cauemarcondes requested a review from a team September 28, 2023 09:07
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 28, 2023 09:07
@cauemarcondes cauemarcondes requested a review from a team September 28, 2023 09:07
danielmitterdorfer
danielmitterdorfer approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I had one (optional and non-blocking) hint. Please feel free to address this. LGTM.

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 28, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 28, 2023

Pinging @elastic/apm-ui (Team:APM)

@cauemarcondes cauemarcondes requested a review from a team as a code owner September 28, 2023 10:43
gbamparop
gbamparop approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

Bamieh
Bamieh approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (telemetry addition)

jbcrail
jbcrail reviewed Sep 28, 2023
View reviewed changes
@mgiota mgiota self-requested a review September 29, 2023 10:31
mgiota
mgiota approved these changes Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable Observability changes LGTM!

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 29, 2023 11:05
@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Oct 2, 2023

@elasticmachine merge upstream

@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Oct 2, 2023

@elasticmachine merge upstream

@cauemarcondes cauemarcondes enabled auto-merge (squash) October 2, 2023 13:10
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 2, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 563 569 +6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 101.0KB 101.1KB +150.0B
Unknown metric groups

API count

id before after diff
observability 572 578 +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

colleenmcginnis
colleenmcginnis approved these changes Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@cauemarcondes cauemarcondes merged commit 0b48b92 into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 2, 2023
@cauemarcondes cauemarcondes deleted the profiling-new-ES-flamegraph-api branch October 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

@mgiota mgiota mgiota approved these changes

@gbamparop gbamparop gbamparop approved these changes

@Bamieh Bamieh Bamieh approved these changes

@jloleysens jloleysens jloleysens approved these changes

+2 more reviewers

@jbcrail jbcrail jbcrail left review comments

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.