Skip to content

[8.10] Fix typecheck foundations (#167060)#167394

Merged
watson merged 14 commits intoelastic:8.10from
watson:fix-typecheck
Sep 28, 2023
Merged

[8.10] Fix typecheck foundations (#167060)#167394
watson merged 14 commits intoelastic:8.10from
watson:fix-typecheck

Conversation

@watson
Copy link
Copy Markdown
Contributor

@watson watson commented Sep 27, 2023

This is a manual backport of #167060 + recent updates to the backported files

This is step one of many for solving #167373

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Sep 27, 2023
@watson watson requested a review from a team September 27, 2023 11:51
@watson watson self-assigned this Sep 27, 2023
This is a manual backport of elastic#167060 + recent updates to the backported files
@watson
Copy link
Copy Markdown
Contributor Author

watson commented Sep 27, 2023

I'm getting fatal: Not a valid object name 8.10 in the Check Types Commit Diff step. I have no clue where that is coming from 🤷‍♂️

@Ikuni17
Copy link
Copy Markdown
Contributor

Ikuni17 commented Sep 27, 2023

I'm getting fatal: Not a valid object name 8.10 in the Check Types Commit Diff step. I have no clue where that is coming from 🤷‍♂️

I couldn't really figure it out either. And running something like git diff --name-only --merge-base origin/8.10 <pr-sha> was working locally. I split the merge-base and diff commands and afaik it produces the same result.

Copy link
Copy Markdown
Member

@delanni delanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@watson watson enabled auto-merge (squash) September 28, 2023 09:31
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson merged commit ae8abdd into elastic:8.10 Sep 28, 2023
@watson watson deleted the fix-typecheck branch September 28, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants