Skip to content

Pick KBN presentation from #166813#167361

Merged
Ikuni17 merged 1 commit intoelastic:mainfrom
Ikuni17:fix/kbn-presentation-types
Sep 26, 2023
Merged

Pick KBN presentation from #166813#167361
Ikuni17 merged 1 commit intoelastic:mainfrom
Ikuni17:fix/kbn-presentation-types

Conversation

@Ikuni17
Copy link
Copy Markdown
Contributor

@Ikuni17 Ikuni17 commented Sep 26, 2023

Summary

We're breaking #166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for Kibana Presenation.

@Ikuni17 Ikuni17 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.11.0 labels Sep 26, 2023
@Ikuni17 Ikuni17 requested a review from a team as a code owner September 26, 2023 21:37
@Ikuni17 Ikuni17 self-assigned this Sep 26, 2023
Copy link
Copy Markdown
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had the exact same fix on my end 👍

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / serverless common UI Index Management Create enrich policy "before all" hook for "shows create enrich policies page and docs link"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @delanni @Ikuni17

@Ikuni17 Ikuni17 merged commit dc3d598 into elastic:main Sep 26, 2023
@Ikuni17 Ikuni17 deleted the fix/kbn-presentation-types branch February 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants