[APM] Add telemetry for calculating global labels used in computing aggrega…#167305
Merged
achyutjhunjhunwala merged 14 commits intoelastic:mainfrom Oct 2, 2023
Merged
Conversation
…tion key for internal metrics
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
pgayvallet
approved these changes
Sep 26, 2023
yngrdyn
reviewed
Oct 2, 2023
|
|
||
| const globalLabelCount = Object.keys(response.fields).length; | ||
|
|
||
| // Skip the top level Labels field which is sometimes present in the response |
Contributor
There was a problem hiding this comment.
Do you know why this happens? Why we get it just sometimes and not always?
Contributor
Author
There was a problem hiding this comment.
Yes, thats the top level labels object. If you see the actual payload, you will see all others are type: keyword and only this one is type: object
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #161983
Adds telemetry for calculating global labels used in computing aggregation key for internal APM Metrics
How to test
Navigate to
internal/apm/debug-telemetryon any of the deployed environmentsYou will find the global_labels count field like this