Skip to content

[Logs+] Improve observability log explorer global search behaviour#167164

Merged
Kerry350 merged 5 commits intoelastic:mainfrom
Kerry350:166854/166912-improve-observability-log-explorer-global-search-behaviour
Sep 27, 2023
Merged

[Logs+] Improve observability log explorer global search behaviour#167164
Kerry350 merged 5 commits intoelastic:mainfrom
Kerry350:166854/166912-improve-observability-log-explorer-global-search-behaviour

Conversation

@Kerry350
Copy link
Copy Markdown
Contributor

@Kerry350 Kerry350 commented Sep 25, 2023

Summary

@Kerry350 Kerry350 self-assigned this Sep 25, 2023
@ghost
Copy link
Copy Markdown

ghost commented Sep 25, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Kerry350 Kerry350 added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Sep 25, 2023
@Kerry350 Kerry350 marked this pull request as ready for review September 25, 2023 19:29
@Kerry350 Kerry350 requested review from a team as code owners September 25, 2023 19:29
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 25, 2023

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes Sep 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

One minor thing during testing because it was mentioned in the ticket description.

Logs Expl still doesn't work.

Screenshot 2023-09-25 at 23 04 08

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Sep 26, 2023 •
edited
Loading

@mohamedhamed-ahmed Thanks for the review 👌

One minor thing during testing because it was mentioned in the ticket description.
Logs Expl still doesn't work.

I've added logs explorer as a keyword, as logs or explorer alone won't fill that requirement.

Screenshot 2023-09-26 at 13 50 49

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Sep 26, 2023

@elasticmachine merge upstream

@Kerry350
Copy link
Copy Markdown
Contributor Author

Kerry350 commented Sep 27, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 27, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityLogExplorer 16.8KB 16.8KB +51.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kerry350

@Kerry350 Kerry350 merged commit d7e8816 into elastic:main Sep 27, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Sep 27, 2023
@semd semd mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jloleysens jloleysens jloleysens approved these changes

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

Assignees

@Kerry350 Kerry350

Labels

backport:skip This PR does not require backporting Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Log Explorer] Apply search keyword to improve global search result [Logs Explorer] Explorer is accessible via global search in the Security projects

6 participants

@Kerry350 @elasticmachine @kibana-ci @jloleysens @mohamedhamed-ahmed @kibanamachine