Skip to content

[ML] Amends the ML app description on the management page#166843

Merged
szabosteve merged 32 commits intoelastic:mainfrom
szabosteve:amend.ml.overview
Oct 2, 2023
Merged

[ML] Amends the ML app description on the management page#166843
szabosteve merged 32 commits intoelastic:mainfrom
szabosteve:amend.ml.overview

Conversation

@szabosteve
Copy link
Copy Markdown
Contributor

@szabosteve szabosteve commented Sep 20, 2023 •
edited
Loading

Summary

Related to: https://github.com/elastic/platform-docs-team/issues/217

This PR updates the ML intro text on the management page and on the ML job list page.

Screenshot 2023-09-21 at 16 41 38

Checklist

Delete any items that are not applicable to this PR.

@szabosteve szabosteve requested a review from a team as a code owner September 20, 2023 14:29
@szabosteve szabosteve changed the title [ML] Amends the ML app description on the management page. [ML] Amends the ML app description on the management page Sep 20, 2023
@szabosteve szabosteve requested a review from lcawl September 20, 2023 14:29
@ghost
Copy link
Copy Markdown

ghost commented Sep 20, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@szabosteve szabosteve added :ml release_note:skip Skip the PR/issue when compiling release notes ui-copy Review of UI copy with docs team is recommended v8.11.0 labels Sep 20, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 20, 2023

Pinging @elastic/ml-ui (:ml)

@szabosteve szabosteve requested a review from a team as a code owner September 20, 2023 16:16
lcawl
lcawl approved these changes Sep 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it doesn't seem like any doc screenshots that are affected

peteharverson
peteharverson approved these changes Sep 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alisonelizabeth
alisonelizabeth reviewed Sep 21, 2023
View reviewed changes
szabosteve
szabosteve commented Sep 21, 2023
View reviewed changes
@szabosteve szabosteve requested a review from gchaps September 27, 2023 07:58
gchaps
gchaps approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM.

szabosteve
szabosteve commented Sep 28, 2023
View reviewed changes
@elastic elastic deleted a comment from kibana-ci Sep 28, 2023
alisonelizabeth
alisonelizabeth approved these changes Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy changes LGTM

@szabosteve szabosteve enabled auto-merge (squash) October 2, 2023 13:54
@szabosteve szabosteve merged commit 7d77742 into elastic:main Oct 2, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 2, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / visualize app visual builder metric Top Hit aggregation should show correct data for string type field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
management 71.1KB 71.1KB -4.0B
ml 3.5MB 3.5MB -4.0B
total -8.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 43.5KB 43.5KB -4.0B
serverlessSearch 30.2KB 30.2KB -4.0B
total -8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 2, 2023
@szabosteve szabosteve deleted the amend.ml.overview branch October 2, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@lcawl lcawl lcawl approved these changes

@sabarasaba sabarasaba Awaiting requested review from sabarasaba

@alisonelizabeth alisonelizabeth Awaiting requested review from alisonelizabeth

+1 more reviewer

@gchaps gchaps gchaps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes ui-copy Review of UI copy with docs team is recommended v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@szabosteve @elasticmachine @kibana-ci @alisonelizabeth @peteharverson @lcawl @gchaps @kibanamachine