Skip to content

Update dependency @elastic/charts to v60 (main)#166799

Merged
markov00 merged 8 commits intomainfrom
renovate/main-@elasticcharts
Oct 2, 2023
Merged

Update dependency @elastic/charts to v60 (main)#166799
markov00 merged 8 commits intomainfrom
renovate/main-@elasticcharts

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Sep 20, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 59.1.0 -> 60.0.0 age adoption passing confidence

Release Notes

elastic/elastic-charts (@​elastic/charts)

v60.0.0

Compare Source

Bug Fixes
Features
BREAKING CHANGES
  • xy: when using the ScaleType.Ordinal for the X scale the legend extra value, representing the last and current hovered value, will not be shown.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Sep 20, 2023
@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Sep 26, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@markov00 markov00 marked this pull request as ready for review September 29, 2023 10:16
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2023

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@drewdaemon
Copy link
Copy Markdown
Contributor

drewdaemon commented Oct 2, 2023 •
edited
Loading

Because of this fix: elastic/elastic-charts#2131, we should no longer need the requestAnimationFrame calls in the expression renderers (example) with this update.

Happy to contribute a commit if helpful.

@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Oct 2, 2023

@drewdaemon can you create a PR to clean it up?

@drewdaemon
Copy link
Copy Markdown
Contributor

drewdaemon commented Oct 2, 2023

PR for removing RAFs. #167785

@drewdaemon
Remove extra RAFs (#167785)
0f00371 
## Summary

As a stop-gap for adding the performance journey, we adding RAF calls to
the renderers because Elastic charts was reporting the render
prematurely. As of elastic/elastic-charts#2131,
the bug in Elastic charts is fixed, so we should remove these.
@stratoula stratoula requested a review from a team as a code owner October 2, 2023 14:16
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 2, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 18.8KB 18.7KB -38.0B
expressionHeatmap 27.2KB 27.2KB -38.0B
expressionMetricVis 4.6KB 4.6KB -38.0B
expressionPartitionVis 40.6KB 40.6KB -36.0B
expressionTagcloud 23.0KB 23.0KB -38.0B
expressionXY 131.1KB 131.1KB -38.0B
total -226.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.3MB 6.2MB -1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00
Copy link
Copy Markdown
Contributor

markov00 commented Oct 2, 2023

@elasticmachine run elasticsearch-ci/docs

@markov00 markov00 enabled auto-merge (squash) October 2, 2023 15:28
@markov00 markov00 merged commit b0a39cd into main Oct 2, 2023
@markov00 markov00 deleted the renovate/main-@elasticcharts branch October 2, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@elasticmachine @drewdaemon @stratoula @kibana-ci @markov00 @nickofthyme @kibanamachine