Skip to content

[Fleet] Make integrations sidebar sticky again#166702

Merged
criamico merged 1 commit intoelastic:mainfrom
criamico:integrations_sidebar_sticky
Sep 19, 2023
Merged

[Fleet] Make integrations sidebar sticky again#166702
criamico merged 1 commit intoelastic:mainfrom
criamico:integrations_sidebar_sticky

Conversation

@criamico
Copy link
Copy Markdown
Member

@criamico criamico commented Sep 19, 2023

Summary

Latest upgrade of EUI removed the isSticky property that we were using in Integrations sidebar.

This PR is adding it back with some css properties.

Screen.Recording.2023-09-19.at.12.40.26.mov

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0 labels Sep 19, 2023
@criamico criamico self-assigned this Sep 19, 2023
@criamico criamico marked this pull request as ready for review September 19, 2023 10:45
@criamico criamico requested a review from a team as a code owner September 19, 2023 10:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 19, 2023

Pinging @elastic/fleet (Team:Fleet)

@ghost
Copy link
Copy Markdown

ghost commented Sep 19, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 19, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / serverless security UI Configure Case "before all" hook in "Configure Case"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +111.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 3a0ac6f into elastic:main Sep 19, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 19, 2023
@criamico criamico deleted the integrations_sidebar_sticky branch September 19, 2023 12:57
@criamico criamico mentioned this pull request Oct 17, 2023
Closed
@nchaulet nchaulet mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@criamico criamico

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@criamico @elasticmachine @kibana-ci @juliaElastic @kibanamachine