[RAM] Text not localized on rules managament table#166700
[RAM] Text not localized on rules managament table#166700guskovaue merged 4 commits intoelastic:mainfrom
Conversation
There was a problem hiding this comment.
You do not need to add these translation because at each release, we have a process to rebuild all these translations. So, It is ok to remove it, you only get error when you have duplicate key.
There was a problem hiding this comment.
@jcger We just had an exact translations we need for that, so I decided to save translators time. And also for testing (to see that we actually have everuthing translated).
Do you think it's safer to delete them for now?
There was a problem hiding this comment.
Didn't knew you speak French, Japanese and Chinese! :P
I would say yes, you should remove them but I'm not 100% sure. My comment was copied from another comment I received in a PR about a year ago cc @XavierM
There was a problem hiding this comment.
@jcger I have a lot of hidden talents :-P.
I've fixed it. Probably you are right. It's safer. And I've alredy tested it with translations.
d61960c to
3dcd171
Compare
|
@elasticmachine merge upstream |
…com:guskovaue/kibana into RAM-165552-text-not-localized-on-mngt-table
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @guskovaue |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Summary
Fixed issue: #165552 for all existing locale.
Looked before:
Now looks like this:
