[ML] Adds Create a data view button to index or saved search selector in ML pages and Transforms management by qn895 · Pull Request #166668 · elastic/kibana

qn895 · 2023-09-18T20:43:16Z

Summary

This PR add Create a data view button to index or saved search selector in ML pages including Index Data Visualizer, AIOps pages, and Data Frame Analytics.

ML pages:

Screen.Recording.2023-09-18.at.15.41.35.mov

Screen.Recording.2023-09-25.at.11.23.05.mov

Transforms

Screen.Recording.2023-09-20.at.09.04.40.mov

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…fix'

peteharverson · 2023-09-22T13:49:50Z

Could this be added for the 'Create job' workflow for Data frame analytics?

qn895 · 2023-09-25T17:09:32Z

Could this be added for the 'Create job' workflow for Data frame analytics?

Yes! Updated here 2f4ceef (#166668). I also allowed creating adhoc data view by deafult. It will successfully create the analytics, with the caveat that cloning the DFA will not work out of the box.

Screen.Recording.2023-09-25.at.11.23.05.mov

…-fix'

peteharverson · 2023-09-26T16:51:48Z

I also allowed creating adhoc data view by default. It will successfully create the analytics, with the caveat that cloning the DFA will not work out of the box.

I think this behavior is fine. The user gets the option in the wizard to create a data view for the results index, and if that is created, the results view will be fully available even without a data view for the source index. On cloning, a clear error is displayed to create the data view if one does not already exist.

peteharverson

Tested and LGTM

elasticmachine · 2023-09-27T14:17:43Z

Pinging @elastic/ml-ui (:ml)

jgowdyelastic · 2023-09-27T16:19:01Z

...plugins/ml/public/application/components/create_data_view_button/create_data_view_button.tsx

+}) => {
+  const { dataViewEditor } = useMlKibana().services;
+  const canEditDataView = Boolean(dataViewEditor?.userPermissions.editDataView());
+  const closeDataViewEditor = useRef<() => void | undefined>();


This is currently not being used.
Looking at other examples, it should be used to close the editor when unmounting the component.

Updated here 2262a7f (#166668)

jgowdyelastic · 2023-09-27T16:23:48Z

...plugins/ml/public/application/components/create_data_view_button/create_data_view_button.tsx

+      />
+    </EuiButton>
+  ) : (
+    <Fragment />


Unless there is a specific reason for this, normally we just return null

Updated here 2262a7f (#166668)

jgowdyelastic · 2023-09-27T16:24:05Z

x-pack/plugins/transform/public/plugin.ts

 import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';
 import type { SavedSearchPublicPluginStart } from '@kbn/saved-search-plugin/public';
 import type { PluginInitializerContext } from '@kbn/core/public';
+import { DataViewEditorStart } from '@kbn/data-view-editor-plugin/public';


Suggested change

import { DataViewEditorStart } from '@kbn/data-view-editor-plugin/public';

import type { DataViewEditorStart } from '@kbn/data-view-editor-plugin/public';

Updated here 2262a7f (#166668)

…views-in-so-finder

jgowdyelastic · 2023-10-02T13:00:02Z

...plugins/ml/public/application/components/create_data_view_button/create_data_view_button.tsx

+  const dataViewEditorRef = useRef<() => void | undefined>();
+
+  const createNewDataView = useCallback(() => {
+    dataViewEditorRef.current = dataViewEditor?.openEditor({


If this ref isn't going to be used to close the editor when navigating away, then I don't think we need the ref at all.
However, I think it would be good to use the ref as it was initially intended to close the editor when this button component is destroyed.

Thanks for catching that, updated here 2a655ac (#166668) so it closes upon unmounting/ navigating away.

…views-in-so-finder

jgowdyelastic

LGTM

kibana-ci · 2023-10-02T14:22:18Z

💚 Build Succeeded

Buildkite Build
Commit: ac68760

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1814	1816	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	3.5MB	3.5MB	+819.0B
`transform`	401.9KB	402.5KB	+685.0B
total			+1.5KB

History

💛 Build #164152 was flaky 3acecf4
💚 Build #162988 succeeded d357075
💔 Build #162956 failed 7431967
💚 Build #161960 succeeded 4820f7b
💔 Build #160411 failed 6b7ac65
💔 Build #160396 failed d9076f613a20cd6b8b92b52a9a8cbdea21e77e72

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Add create a data view button to saved object finder page

019e778

qn895 self-assigned this Sep 18, 2023

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

bdb8958

…fix'

qn895 requested review from jgowdyelastic and peteharverson September 19, 2023 01:04

qn895 added release_note:enhancement :ml v8.1.1 labels Sep 19, 2023

qn895 changed the title ~~[ML] Add Create a data view button to index or saved search selector in ML pages~~ [ML] Add Create a data view button to index or saved search selector in ML pages and Transforms management Sep 20, 2023

qn895 added the Feature:Transforms Transforms label Sep 20, 2023

Add editor flyout for transform

3a5f171

qn895 force-pushed the ml-add-create-data-views-in-so-finder branch from d9076f6 to 3a5f171 Compare September 20, 2023 14:19

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

6b7ac65

…fix'

qn895 added 2 commits September 25, 2023 11:43

Merge upstream/main into branch

f8238f8

Refactor so DFA also have access

2f4ceef

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

4820f7b

…-fix'

peteharverson added v8.11.0 and removed v8.1.1 labels Sep 26, 2023

peteharverson approved these changes Sep 26, 2023

View reviewed changes

Merge upstream/main into branch

7431967

qn895 marked this pull request as ready for review September 27, 2023 14:17

qn895 requested a review from a team as a code owner September 27, 2023 14:17

Fix deps.dataViewEditor

d357075

jgowdyelastic reviewed Sep 27, 2023

View reviewed changes

qn895 added 2 commits September 29, 2023 13:25

Fix data view

2262a7f

Merge remote-tracking branch 'upstream/main' into ml-add-create-data-…

3acecf4

…views-in-so-finder

jgowdyelastic reviewed Oct 2, 2023

View reviewed changes

qn895 added 2 commits October 2, 2023 08:17

fix editor

2a655ac

Merge remote-tracking branch 'upstream/main' into ml-add-create-data-…

ac68760

…views-in-so-finder

jgowdyelastic approved these changes Oct 2, 2023

View reviewed changes

qn895 merged commit 007c341 into elastic:main Oct 2, 2023

qn895 deleted the ml-add-create-data-views-in-so-finder branch October 2, 2023 14:45

kibanamachine added the backport:skip This PR does not require backporting label Oct 2, 2023

szabosteve changed the title ~~[ML] Add Create a data view button to index or saved search selector in ML pages and Transforms management~~ [ML] Adds Create a data view button to index or saved search selector in ML pages and Transforms management Oct 12, 2023

	import { DataViewEditorStart } from '@kbn/data-view-editor-plugin/public';
	import type { DataViewEditorStart } from '@kbn/data-view-editor-plugin/public';

Conversation

qn895 commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

peteharverson commented Sep 22, 2023

Uh oh!

qn895 commented Sep 25, 2023

Uh oh!

peteharverson commented Sep 26, 2023

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 27, 2023

Uh oh!

jgowdyelastic Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qn895 Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

qn895 Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

qn895 Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

qn895 Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Oct 2, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

qn895 commented Sep 18, 2023 •

edited

Loading

jgowdyelastic Sep 27, 2023 •

edited

Loading

qn895 Oct 2, 2023 •

edited

Loading