Skip to content

[Security Solution][Endpoint] Update description list on endpoint details flyout#165937

Merged
ashokaditya merged 5 commits intoelastic:mainfrom
ashokaditya:fix/dw-endpoint-details-flyout-7563
Sep 7, 2023
Merged

[Security Solution][Endpoint] Update description list on endpoint details flyout#165937
ashokaditya merged 5 commits intoelastic:mainfrom
ashokaditya:fix/dw-endpoint-details-flyout-7563

Conversation

@ashokaditya
Copy link
Copy Markdown
Member

@ashokaditya ashokaditya commented Sep 7, 2023 •
edited
Loading

Summary

This PR fixes a UX bug that was a result of EUI upgrade where the description list contents were misaligned. The EuiDescriptionList component should take a set of column widths and column and row gutter sizes to allow for adequate spacing between text elements.

before
Screenshot 2023-09-07 at 10 16 11 AM

with this fix
Screenshot 2023-09-07 at 10 15 26 AM

see /pull/165047

Checklist

@ashokaditya ashokaditya self-assigned this Sep 7, 2023
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.11.0 labels Sep 7, 2023
@ashokaditya ashokaditya marked this pull request as ready for review September 7, 2023 08:17
@ashokaditya ashokaditya requested a review from a team as a code owner September 7, 2023 08:17
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 7, 2023

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

tomsonpl
tomsonpl approved these changes Sep 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! Thanks :)

gergoabraham
gergoabraham approved these changes Sep 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ashokaditya ashokaditya enabled auto-merge (squash) September 7, 2023 09:24
@ashokaditya
Copy link
Copy Markdown
Member Author

ashokaditya commented Sep 7, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 7, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "after all" hook in "Columns selection initialization and update"
  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "before all" hook in "Columns selection initialization and update"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB -5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 1c62d1c into elastic:main Sep 7, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 7, 2023
@ashokaditya ashokaditya deleted the fix/dw-endpoint-details-flyout-7563 branch September 7, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-defend-workflows

Assignees

@ashokaditya ashokaditya

Labels

backport:skip This PR does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ashokaditya @elasticmachine @kibana-ci @tomsonpl @gergoabraham @kibanamachine