[SecuritySolution] Add SecuritySolution sample data by angorayc · Pull Request #164052 · elastic/kibana

angorayc · 2023-08-16T11:06:04Z

Summary

Test environment: https://p.elstc.co/paste/wPDsxkBY#4icff2HWTA784+qCm7q1p-Ct3SVF4WhiM7VdZojwjpJ

Steps to verify:
Try sample data > Security Solution data > Add data

It should populate sample data: auditbeat, logs, and alerts
It shouldn't affect existing auditbeat, logs or alerts data
It should install relevant saved objects and ingest pipelines

Try sample data > Security Solution data > Remove data

It should remove sample data
It shouldn't affect existing auditbeat, logs or alerts data
It should remove relevant saved objects and ingest pipelines
Add Security Solution sample data:

Install sample data

Uploading Screen Recording 2023-09-20 at 20.48.28.mov…

Remove sample data

remove_sample_data.mov

Update fields with ingest pipeline:

Create kibana_sample_data_securitysolution_alerts index
Add sample alert index to security solution alerts alias (and the alerts alias should not be deleted when sample data removed)

Create kibana_sample_data_securitysolution_auditbeat index
Add Auditbeat sample index to an alias that matches auditbeat-* pattern:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

…-ref HEAD~1..HEAD --fix'

…data

…fix'

…-fix'

angorayc · 2023-09-08T14:31:16Z

-              index: {
-                ...dataIndex.indexSettings,
-              },
+          settings: {


The use of the 'body' key has been deprecated, so moving the nested keys to the top level object.

node_modules/@elastic/elasticsearch/lib/api/typesWithBodyKey.d.ts line 8755

angorayc · 2023-09-08T14:32:35Z

-          },
-          settings: {
-            index: {},
+        mappings: {


The use of the 'body' key has been deprecated, so moving the nested keys to the top level object.

node_modules/@elastic/elasticsearch/lib/api/typesWithBodyKey.d.ts line 8755

…data

angorayc · 2023-09-12T10:45:07Z


    const resp = await esClient.asCurrentUser.bulk({
      body: bulk,
+      refresh: true,


Before - There were chances that new indices haven't refreshed before the next listing request:

incorrect_add_data_state.mov

After:

Screen.Recording.2023-09-12.at.11.41.42.mov

angorayc · 2023-09-20T20:09:00Z

I've tried to run in locally, just spun up your branch in stateful mode and clicked "Add data", and toast message with "Internal error" appears (the flights sample data gets installed as usual):

Thanks for pointing this out, I messed up the dashboard references in 2c998fd#diff-c047af719d3de4f7878bbfabb1b9b22c1e56fddf51d9ca9c1fa97e48235b7704. It should work now.

…-fix'

…data

vadimkibana

Great job 👍 !

ferenrigue · 2023-09-25T15:41:42Z

Reviewed!

kertal

I'm not sure, why @elastic/kibana-data-discovery team is assigned to review since there seems to be no code ownership here, but I just needed to test something in Security , and so I've been using this PR, and I works like expected. It's really nice to have this available with just a few clicks, thanks a lot 👍

stephmilovic · 2023-09-25T15:52:06Z

Resolves #124463

stephmilovic · 2023-09-25T16:01:30Z

@elasticmachine merge upstream

stephmilovic

I think we need to handle the sourcerer specially for this case. We can discuss in our meeting in 20 mins :)

kibana-ci · 2023-09-26T10:48:28Z

💔 Build Failed

Failed CI Steps

Check Types Commit Diff

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`home`	109	110	+1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`home`	0	1	+1

Unknown metric groups

API count

id	before	after	diff
`home`	149	150	+1

ESLint disabled line counts

id	before	after	diff
`securitySolution`	454	456	+2

References to deprecated APIs

id	before	after	diff
`home`	71	70	-1

Total ESLint disabled count

id	before	after	diff
`securitySolution`	521	523	+2

History

💔 Build #161888 failed a1b14fd
💔 Build #161758 failed f169ac6
💚 Build #161466 succeeded 554d7b2
💔 Build #161317 failed d52fb4e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

angorayc · 2023-09-26T10:57:25Z

This PR will not make it in 8.11 as here are some more items to do:

Write an issues for onboarding sample data @paulewing
Confirm if we want to add Sample data view to alerts page data view @paulewing
Could tag sample alerts / events with a sample data tag to indicate it's a sample data @paulewing
Confirm with @james.spiteri if we should only install sample events and sample rules . Let it automatically generate alerts from sample events @paulewing
Check with @james.spiteri if we should modify any values in the sample data @paulewing
Investigate opening alert flyout automatically @angorayc

angorayc and others added 7 commits August 16, 2023 12:05

add sample data

bd68452

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

97806b2

…-ref HEAD~1..HEAD --fix'

sample data

5686a21

Merge branch 'sample-data' of github.com:angorayc/kibana into sample-…

4555814

…data

alias

d98d8f0

add alerts data

8bdd9b9

add alerts data

79dae69

angorayc changed the title ~~add sample data~~ Add SecuritySolution sample data Aug 28, 2023

kibanamachine and others added 6 commits August 28, 2023 21:18

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

a43d0aa

…fix'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

cfe9766

…-fix'

Merge branch 'main' into sample-data

9e60cff

fix unit test

665162e

update sample dashboard data view

03a03ed

Merge branch 'main' of github.com:elastic/kibana into sample-data

f49e752

angorayc commented Sep 8, 2023

View reviewed changes

angorayc and others added 2 commits September 8, 2023 16:12

Merge branch 'main' into sample-data

30dd1a6

revert

4deb8b3

angorayc added the ci:cloud-deploy Create or update a Cloud deployment label Sep 11, 2023

angorayc and others added 6 commits September 11, 2023 09:17

Merge branch 'main' into sample-data

7f70e62

fix types

2b94611

Merge branch 'sample-data' of github.com:angorayc/kibana into sample-…

c4673d3

…data

revert change

f0594be

revert changes

25111a4

fix map extra savedobjects added

40f72db

angorayc commented Sep 12, 2023

View reviewed changes

angorayc and others added 4 commits September 12, 2023 11:55

update uninstall route

42b2153

Merge branch 'main' into sample-data

35c01f2

fix space aware saved objects

675da78

fix saved object references

db3c148

angorayc added 2 commits September 20, 2023 20:34

revert

12f0ce2

fix types

f3c7235

kibanamachine and others added 7 commits September 20, 2023 20:35

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

8c9dfa3

…-fix'

fix i18n

b653e2e

Merge branch 'sample-data' of github.com:angorayc/kibana into sample-…

d751cc2

…data

fix types

7bd79aa

revert

9ac661f

Merge branch 'main' into sample-data

6300f5c

move image path

ad44552

angorayc changed the title ~~Add SecuritySolution sample data~~ [SecuritySolution] Add SecuritySolution sample data Sep 21, 2023

Merge branch 'main' into sample-data

413738e

vadimkibana approved these changes Sep 22, 2023

View reviewed changes

semd approved these changes Sep 22, 2023

View reviewed changes

angorayc added 3 commits September 22, 2023 16:54

Merge branch 'main' into sample-data

d52fb4e

Merge branch 'main' into sample-data

554d7b2

Merge branch 'main' into sample-data

f169ac6

kertal approved these changes Sep 25, 2023

View reviewed changes

Merge branch 'main' into sample-data

a1b14fd

stephmilovic requested changes Sep 25, 2023

View reviewed changes

angorayc removed the v8.11.0 label Sep 25, 2023

Merge branch 'main' into sample-data

7b56e66

angorayc closed this Apr 15, 2024

spong mentioned this pull request May 9, 2024

Security solution sample data #182979

Draft

paulinashakirova mentioned this pull request Apr 20, 2026

[Serverless][Home app] Fix failing test to (un)install sample datasets #264232

Open

Conversation

angorayc commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

angorayc Sep 8, 2023

Choose a reason for hiding this comment

Uh oh!

angorayc Sep 8, 2023

Choose a reason for hiding this comment

Uh oh!

angorayc Sep 12, 2023

Choose a reason for hiding this comment

Uh oh!

angorayc commented Sep 20, 2023

Uh oh!

vadimkibana left a comment

Choose a reason for hiding this comment

Uh oh!

ferenrigue commented Sep 25, 2023

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephmilovic commented Sep 25, 2023

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

angorayc commented Sep 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

angorayc commented Aug 16, 2023 •

edited

Loading

stephmilovic commented Sep 25, 2023 •

edited

Loading

kibana-ci commented Sep 26, 2023 •

edited

Loading