Skip to content

[8.9] [Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test (#162839)#163766

Merged
dhurley14 merged 2 commits intoelastic:8.9from
dhurley14:backport/8.9/pr-162839
Aug 12, 2023
Merged

[8.9] [Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test (#162839)#163766
dhurley14 merged 2 commits intoelastic:8.9from
dhurley14:backport/8.9/pr-162839

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

…ewer cypress test (elastic#162839)

## Summary

Ref: elastic#162569

The test was trying to load the exceptions tab before the rule details
page loaded. Now we wait for the rule tab to load before continuing.
Something I was unaware of was that `cy.url()` will [automatically
retry](https://docs.cypress.io/api/commands/url#Assertions) until all
chained assertions have passed, which I think can be an easy way to fix
future flake issues where cypress tries to click on an element before
the new page loads.

(cherry picked from commit 7b3cc8f)

# Conflicts:
#	x-pack/plugins/security_solution/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14 dhurley14 merged commit 93797e6 into elastic:8.9 Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants