Skip to content

[data views] fields_for_wildcard - disable schema response validation#159758

Merged
mattkime merged 1 commit intoelastic:mainfrom
mattkime:disable_fields_for_wildcard_schema_response_validation
Jun 16, 2023
Merged

[data views] fields_for_wildcard - disable schema response validation#159758
mattkime merged 1 commit intoelastic:mainfrom
mattkime:disable_fields_for_wildcard_schema_response_validation

Conversation

@mattkime
Copy link
Copy Markdown
Contributor

@mattkime mattkime commented Jun 14, 2023

Summary

Response validation is failing when there are field conflicts. Disable response validation until a complete schema can be created.

Problem was introduced in #158608

@mattkime mattkime changed the title disable schema response validation [data views] fields_for_wildcard - disable schema response validation Jun 14, 2023
@mattkime mattkime self-assigned this Jun 14, 2023
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// release_note:skip Skip the PR/issue when compiling release notes labels Jun 14, 2023
@mattkime mattkime marked this pull request as ready for review June 14, 2023 23:39
@mattkime mattkime requested a review from a team as a code owner June 14, 2023 23:39
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime requested a review from davismcphee June 14, 2023 23:40
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #1 / Export rules shows a modal saying that no rules can be exported if all the selected rules are prebuilt

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 493 497 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit 4a8bbd9 into elastic:main Jun 16, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This PR does not require backporting labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants