Skip to content

[Security Solution] [Investigation Guides] Use markdown toolbar disable ability, along with new icon#159718

Merged
kqualters-elastic merged 2 commits intoelastic:mainfrom
kqualters-elastic:insight-license-toolbar
Jun 16, 2023
Merged

[Security Solution] [Investigation Guides] Use markdown toolbar disable ability, along with new icon#159718
kqualters-elastic merged 2 commits intoelastic:mainfrom
kqualters-elastic:insight-license-toolbar

Conversation

@kqualters-elastic
Copy link
Copy Markdown
Contributor

@kqualters-elastic kqualters-elastic commented Jun 14, 2023

Summary

To be merged after elastic/eui#6840 is included in an Eui release and said release is merged to kibana.

Makes use of the new isDisabled prop exposed to EuiMarkdownToolbar components, and disables the button with appropriate hover text if license level is not appropriate.

image

Checklist

@kqualters-elastic kqualters-elastic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.9.0 labels Jun 14, 2023
@kqualters-elastic kqualters-elastic marked this pull request as ready for review June 15, 2023 20:22
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner June 15, 2023 20:22
PhilippeOberti
PhilippeOberti approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM!

PhilippeOberti
PhilippeOberti approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM!

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 15, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Tests #4 / Alerts generated by building block rules Alerts should be visible on the Rule Detail page and not visible on the Overview page
  • [job] [logs] Explore - Security Solution Tests #2 / Entity Analytics Dashboard With anomalies data renders table with pagination

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.8MB 10.8MB +2.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit 0b96f1d into elastic:main Jun 16, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 16, 2023
@kqualters-elastic kqualters-elastic deleted the insight-license-toolbar branch June 16, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kqualters-elastic @kibana-ci @PhilippeOberti @kibanamachine