Skip to content

[Lens] Add new Metric formatter migrations#159539

Merged
dej611 merged 10 commits intoelastic:mainfrom
dej611:fix/metric-migrations
Jun 15, 2023
Merged

[Lens] Add new Metric formatter migrations#159539
dej611 merged 10 commits intoelastic:mainfrom
dej611:fix/metric-migrations

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Jun 13, 2023 •
edited
Loading

Summary

Part of 54306
Required #158468 to be merged first.

This PR integrates only the migration part of the new Metric new formatter task.

This migration implementation defines takes the simplest route for the migration route of metric visualization formatter:

  • if any custom formatter is set in Lens, then apply a compact flag on it to keep it consistent
  • if Default formatter is set in Lens, then assume nothing and let the regular formatter hierarchy do its own work

Example

Original dashboard

image

After migration

image

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Lens v8.9.0 labels Jun 13, 2023
@dej611 dej611 added the release_note:skip Skip the PR/issue when compiling release notes label Jun 13, 2023
@dej611 dej611 marked this pull request as ready for review June 13, 2023 11:08
@dej611 dej611 requested review from a team as code owners June 13, 2023 11:08
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 13, 2023

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@dej611 dej611 mentioned this pull request Jun 13, 2023
Closed
stratoula
stratoula approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I tested locally with some of my dashboards and it works fine!

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 15, 2023

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 493 497 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 536a8d4 into elastic:main Jun 15, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dej611 @elasticmachine @kibana-ci @pgayvallet @stratoula @kibanamachine