Skip to content

[6.x] Advanced Settings - Image Input (#15342)#15829

Merged
kobelb merged 1 commit intoelastic:6.xfrom
kobelb:backport/6.x/pr-15342
Jan 3, 2018
Merged

[6.x] Advanced Settings - Image Input (#15342)#15829
kobelb merged 1 commit intoelastic:6.xfrom
kobelb:backport/6.x/pr-15342

Conversation

@kobelb
Copy link
Copy Markdown
Contributor

@kobelb kobelb commented Jan 3, 2018

Backports pull request #15342 to 6.x

* Beginning to work on image advanced setting type

* Making the maxSize code and UI more user-friendly (hopefully).

* Getting rid of that border, I was using the wrong class

* Displaying an image for the preview

* Not displaying the image if we don't have a value

* Removing no longer used code

* Adding explicit throw in the subscription to make our intents more clear

* Changing some of the Observable style based on  input from the peer review

* Using the maxSizeKB option to enforce the size

* Adding support for no max

* Throwing better errors

* No longer duplicated the multiple usage error message

* Using the maxSize attribute to control the max size of the settings

* No longer using JSON.stringify, it's already a string and that approach
won't really do anything for other data-types

* Extracting validate to it's own method

* No longer hardcoding the maxLength validation in the uiSettings

* Using a Joi schema instead

* Punting on server-side validation for the time being
@kobelb kobelb added the backport This PR is a backport of another PR label Jan 3, 2018
@kobelb kobelb merged commit 55c2ca8 into elastic:6.x Jan 3, 2018
@kobelb kobelb deleted the backport/6.x/pr-15342 branch January 3, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant