[6.x] Advanced Settings - Image Input (#15342)#15829
Merged
kobelb merged 1 commit intoelastic:6.xfrom Jan 3, 2018
Merged
Conversation
* Beginning to work on image advanced setting type * Making the maxSize code and UI more user-friendly (hopefully). * Getting rid of that border, I was using the wrong class * Displaying an image for the preview * Not displaying the image if we don't have a value * Removing no longer used code * Adding explicit throw in the subscription to make our intents more clear * Changing some of the Observable style based on input from the peer review * Using the maxSizeKB option to enforce the size * Adding support for no max * Throwing better errors * No longer duplicated the multiple usage error message * Using the maxSize attribute to control the max size of the settings * No longer using JSON.stringify, it's already a string and that approach won't really do anything for other data-types * Extracting validate to it's own method * No longer hardcoding the maxLength validation in the uiSettings * Using a Joi schema instead * Punting on server-side validation for the time being
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports pull request #15342 to 6.x