Skip to content

[8.8] [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)#156763

Merged
kibanamachine merged 1 commit intoelastic:8.8from
kibanamachine:backport/8.8/pr-156629
May 5, 2023
Merged

[8.8] [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)#156763
kibanamachine merged 1 commit intoelastic:8.8from
kibanamachine:backport/8.8/pr-156629

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

…tor UI fixes (elastic#156629)

## Summary

This PR addresses adding safeguards to the 'block' action around FIM
capabilities in D4C (cloud_defend)
see: https://github.com/elastic/cloud-defend/issues/337

It also fixes a few bugs:
1. updates not being reflected in the yaml editor side when changed on
the UI side (after yaml editor viewed for first time).
2. the yaml -> json conversion function was mutating the original
selector/response when deleting the type property. which would cause the
item to dissapear under certain situations.

### Screenshots

![image](https://user-images.githubusercontent.com/16198204/236331957-65fa0a5b-cab7-427c-998d-a3eea77a2820.png)

![image](https://user-images.githubusercontent.com/16198204/236334888-c72f1725-e428-45d8-b514-2ed0a072a687.png)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 587cca4)
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudDefend 256.9KB 258.6KB +1.8KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mitodrummer

@kibanamachine kibanamachine merged commit a371c7b into elastic:8.8 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants