[8.8] [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)#156763
Merged
kibanamachine merged 1 commit intoelastic:8.8from May 5, 2023
Conversation
…tor UI fixes (elastic#156629) ## Summary This PR addresses adding safeguards to the 'block' action around FIM capabilities in D4C (cloud_defend) see: https://github.com/elastic/cloud-defend/issues/337 It also fixes a few bugs: 1. updates not being reflected in the yaml editor side when changed on the UI side (after yaml editor viewed for first time). 2. the yaml -> json conversion function was mutating the original selector/response when deleting the type property. which would cause the item to dissapear under certain situations. ### Screenshots   ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 587cca4)
2 tasks
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @mitodrummer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.8:Questions ?
Please refer to the Backport tool documentation