Skip to content

[6.x] EUI: Reset CSS #2 (#15657)#15676

Merged
cjcenizal merged 1 commit intoelastic:6.xfrom
cjcenizal:backport/6.x/pr-15657
Dec 19, 2017
Merged

[6.x] EUI: Reset CSS #2 (#15657)#15676
cjcenizal merged 1 commit intoelastic:6.xfrom
cjcenizal:backport/6.x/pr-15657

Conversation

@cjcenizal
Copy link
Copy Markdown
Contributor

Backports the following commits to 6.x:

* Add EUI v0.0.7 as a dependency.
- Add support for using dark theme EUI CSS in Dashboard.
- Set light theme as the default.
- Add comments to chrome.jade about role of theme node.
- Add (WTFPL OR MIT) to acceptable licenses.

* Remove old reset CSS.
- Remove naked element selectors from base.less.
- Remove Bootstrap resets.
- Remove UI Framework reset.
- Remove unused reset styles from UI Framework.

* Fix CSS regressions caused by removal of CSS reset.
- Replace usage of sr-only with euiScreenReaderOnly.
- Apply euiButtonEmpty classes to the 'Add a filter' button.
- Fix Notification padding and layout.
- Apply euiTabs styles to Timepicker mode tabs.
- Fix layout of Available Fields heading in Discover.
- Add padding to Popular Fields container in Discover.
- Push down Selected Fields heading in Discover sidebar.
- Fix appearance of links in Discover sidebar.
- Fix height of pills in Filter Bar.

* Fix timepicker tests.
- Remove kbn-accessible-click from timepicker buttons.

* Fix functional tests.
- Use byCssSelector inside of testSubjects.find.
- Delete flaky view_edit.js test: 'when time changed is stored with dashboard'.
- Delete flaky view_edit.js test: 'and preserves edits on cancel > when time changed is stored with dashboard'.
- Delete flake Gauge Chart tests. EUI changed the font size, and the text within the gauges doesn't render when the window is too small.
@cjcenizal cjcenizal added the backport This PR is a backport of another PR label Dec 19, 2017
@cjcenizal cjcenizal merged commit d67d620 into elastic:6.x Dec 19, 2017
@cjcenizal cjcenizal deleted the backport/6.x/pr-15657 branch December 19, 2017 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant