Don't apply query:queryString:options to query_string filters#15640
Don't apply query:queryString:options to query_string filters#15640Bargs merged 4 commits intoelastic:masterfrom
Conversation
|
After thinking about this some more, I think it might actually make sense to add the |
|
@lukasolson I agree those should have |
|
Can you add breaking change docs for this in this PR? I think this would be the first one for 7.0, so you might need to do some basic setup for the 7.0 breaking change docs. |
lukasolson
left a comment
There was a problem hiding this comment.
LGTM, just made a recommendation to add a test.
There was a problem hiding this comment.
Could you just add a simple test here that verifies that the query:queryString:options aren't added in?
|
@Bargs Did this PR fall through the cracks? |
|
I need to add that test and update the docs. Just hasn't been a priority vs other stuff since it won't ship till 7.0. |
|
Since this isn't active right now I'm removing myself as a reviewer, just to clean up my "reviews requested of you" view. Just pop me back on whenever it's ready to go again. |
💔 Build Failed |
454d9b1 to
1e3042d
Compare
|
Rebased and added the breaking change doc @epixa asked for. Also added the test @lukasolson asked for. @stacey-gammon please take another look. |
💔 Build Failed |
💚 Build Succeeded |
Fixes #15527
Lukas and I chatted over Slack and we both agreed it didn't really make sense to apply
query:queryString:optionsto query_string filters. If someone is using the advanced query DSL editor to create a query_string filter they probably want full control over it.This is a breaking change so it will only go in 7.0. In 6.x users should use one of the workarounds.