[Index Management] Migrate code editors to Monaco#155598
Merged
sabarasaba merged 3 commits intoelastic:mainfrom Apr 25, 2023
Merged
[Index Management] Migrate code editors to Monaco#155598sabarasaba merged 3 commits intoelastic:mainfrom
sabarasaba merged 3 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @sabarasaba |
Contributor
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
yuliacech
approved these changes
Apr 25, 2023
Contributor
yuliacech
left a comment
There was a problem hiding this comment.
Thanks a lot, @sabarasaba!
Changes LGTM, tested locally
This was referenced Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #107215
Summary
This PR removes the dependency this plugin has on ace editor in favour of Monaco. Note that
CodeEditoris a kibana wide abstraction built on top of Monaco and located at@kbn/kibana-react-plugin/public.Migrated to
Monacoapplication/components/shared/components/wizard_steps/step_aliases.tsxapplication/components/shared/components/wizard_steps/step_settings.tsxHow to test
yarn es snapshot --license=trial -E path.repo=/tmp/es-backupsand kibana withyarn startStack Management->Index Management->Index Templatesand create a new oneScreenshots