[ML] Change point detection: support for multiple metric and split fields by darnautov · Pull Request #154237 · elastic/kibana

darnautov · 2023-04-03T12:45:39Z

Summary

Adds support for multiple metric and split fields
Updates the change point results layout to the table view
Adds support for viewing selected change points

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

There is one issue about the aria-expanded attribute not being allowed for the EuiAccordion button element used as div, but it has to be fixed on the EUI side. See elastic/eui#6689.

This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

darnautov · 2023-04-04T08:54:38Z

@elasticmachine merge upstream

…nts' into ml-151592-change-point-enhancements

elasticmachine · 2023-04-04T13:55:41Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx

…t-enhancements

darnautov · 2023-04-11T15:20:21Z

@elasticmachine merge upstream

qn895 · 2023-04-11T15:24:52Z

x-pack/plugins/aiops/public/components/change_point_detection/fields_config.tsx

+
+  const onChange = useCallback(
+    (update: FieldConfig, index: number) => {
+      fieldConfigs.splice(index, 1, update);


Did we want to mutate fieldConfigs in place here? Considering we didn't for onAdd.

qn895 · 2023-04-11T15:30:06Z

Latest code changes LGTM 🎉

walterra

Really like that update!

In the latest version I tested, the annotations didn't show up unfortunately. There's also this strange hovering effect where hovering in the dropdowns triggers hovering in non-related items:

One other thing I noticed is the loading behaviour: When changing the split field and there's some loading time, the empty prompt let's me think there are no results, just the very top left global loading indicator is running. After a while though the table with results appears. It would be great if we could show a loading skeleton or similar instead of the empty prompt.

walterra · 2023-04-12T08:23:56Z

x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx

+  const defaultSorting = {
+    sort: {
+      field: 'p_value',
+      // Lower p_value indicates a bigger change point, hence the acs sorting


Nit: Type acs => asc

walterra · 2023-04-12T09:53:25Z

x-pack/plugins/aiops/public/components/change_point_detection/charts_grid.tsx

+      <EuiFlexGrid columns={resultPerPage.length >= 2 ? 2 : 1} responsive gutterSize={'m'}>
+        {resultPerPage.map((v) => {
+          return (
+            <EuiFlexItem key={v.group?.value ?? 'single_metric'}>


With the update in this PR to be able to select items from different groups, I was able to hit a Warning: Encountered two children with the same key for this. For example, with the cloudwatch dataset I create this setup (NetworkIn/NetworkOut by region):

Then from both metrics I selected the same field/value (region:ap-northwest-1) which will trigger the error in the flyout

darnautov · 2023-04-12T09:53:43Z

@walterra thanks for checking it!

In the latest version I tested, the annotations didn't show up unfortunately.

Indeed, with my latest refactoring I accidentally changed the wrong property, fixed in a2da9d2

There's also this strange hovering effect where hovering in the dropdowns triggers hovering in non-related items:

This behaviour comes from the EuiAccordion. I wonder if we should change it 🤔

When changing the split field and there's some loading time, the empty prompt let's me think there are no results, just the very top left global loading indicator is running. After a while though the table with results appears. It would be great if we could show a loading skeleton or similar instead of the empty prompt.

Updated: enhancements for the loading behaviour were added here

darnautov · 2023-04-12T13:27:24Z

@elasticmachine merge upstream

kibana-ci · 2023-04-12T13:52:44Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #8

Test Failures

[job] [logs] FTR Configs #8 / machine learning - data visualizer index based with farequote KQL saved search displays index details
[job] [logs] FTR Configs #8 / machine learning - data visualizer index based with farequote lucene saved search displays index details

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	474	479	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	759.6KB	766.1KB	+6.5KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	436	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	512	515	+3

History

💔 Build #119385 failed 7f8fd6f
💔 Build #119320 failed 156eb07
💔 Build #119303 failed a2da9d2
💚 Build #119070 succeeded 1009be0
💚 Build #119049 succeeded 364b0b2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

peteharverson

LGTM. Great addition, and I like the new loading indicator!

walterra

Latest changes LGTM.

darnautov added 8 commits March 27, 2023 14:30

compressed view

9bd45d4

support for multiple metrics and series

dd1cf0a

change_points_table.tsx

a16aa6c

layout update

38c6909

fix sorting

378cb78

loading state for the table, move empty state

f1f359e

improve deps check

1f63dd5

view selected change points

265b57e

darnautov added release_note:enhancement :ml Team:ML Team label for ML (also use :ml) t// v8.8.0 labels Apr 3, 2023

darnautov requested a review from walterra April 3, 2023 12:45

darnautov self-assigned this Apr 3, 2023

darnautov added 4 commits April 3, 2023 14:54

hasSelectedChangePoints

fca2fc4

filter excluded change points types

ad53ff7

fix key

092eb9e

limit field configs

809bf04

kibanamachine and others added 4 commits April 4, 2023 04:54

Merge branch 'main' into ml-151592-change-point-enhancements

4018e84

Merge remote-tracking branch 'origin/ml-151592-change-point-enhanceme…

1fad360

…nts' into ml-151592-change-point-enhancements

fix support for relative time range

a8f3367

responsive layout

d342d68

darnautov mentioned this pull request Apr 4, 2023

[ML] Change point detection enhancements #151592

Closed

6 tasks

darnautov requested a review from qn895 April 4, 2023 13:55

darnautov marked this pull request as ready for review April 4, 2023 13:55

darnautov requested a review from a team as a code owner April 4, 2023 13:55

darnautov added the ci:cloud-deploy Create or update a Cloud deployment label Apr 4, 2023

qn895 reviewed Apr 4, 2023

View reviewed changes

x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx Show resolved Hide resolved

darnautov added 6 commits April 6, 2023 15:35

fix an error when no metric field exists

9997d2d

apply query

4059f57

Merge remote-tracking branch 'origin/main' into ml-151592-change-poin…

b3a9c4b

…t-enhancements

Merge with origin/main

605747e

hook for chart props

4ec1978

tooltip for viewing selected charts

364b0b2

darnautov requested a review from peteharverson April 11, 2023 14:21

Merge branch 'main' into ml-151592-change-point-enhancements

1009be0

qn895 reviewed Apr 11, 2023

View reviewed changes

qn895 approved these changes Apr 11, 2023

View reviewed changes

walterra reviewed Apr 12, 2023

View reviewed changes

fix annotation prop

a2da9d2

walterra reviewed Apr 12, 2023

View reviewed changes

darnautov added 3 commits April 12, 2023 12:17

fix typo, update key

8e7e204

fix grid pagination

156eb07

improve loading behavior

7f8fd6f

darnautov requested a review from walterra April 12, 2023 12:32

Merge branch 'main' into ml-151592-change-point-enhancements

537fee5

darnautov removed the ci:cloud-deploy Create or update a Cloud deployment label Apr 12, 2023

peteharverson approved these changes Apr 12, 2023

View reviewed changes

walterra approved these changes Apr 12, 2023

View reviewed changes

darnautov merged commit c3e6e70 into elastic:main Apr 12, 2023

kibanamachine added the backport:skip This PR does not require backporting label Apr 12, 2023

darnautov deleted the ml-151592-change-point-enhancements branch April 12, 2023 15:59

peteharverson changed the title ~~[ML] Support multiple change point requests~~ [ML] Change point detection: support for multiple metric and split fields Apr 21, 2023

Conversation

darnautov commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

darnautov commented Apr 4, 2023

Uh oh!

elasticmachine commented Apr 4, 2023

Uh oh!

Uh oh!

darnautov commented Apr 11, 2023

Uh oh!

qn895 Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

qn895 commented Apr 11, 2023

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

walterra Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

walterra Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

darnautov commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darnautov commented Apr 12, 2023

Uh oh!

kibana-ci commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

darnautov commented Apr 3, 2023 •

edited

Loading

darnautov commented Apr 12, 2023 •

edited

Loading

kibana-ci commented Apr 12, 2023 •

edited

Loading