Skip to content

[maps] fix RegionMap chart type does not work with reporting#153492

Merged
nreese merged 10 commits intoelastic:mainfrom
nreese:issue_153455_2
Mar 27, 2023
Merged

[maps] fix RegionMap chart type does not work with reporting#153492
nreese merged 10 commits intoelastic:mainfrom
nreese:issue_153455_2

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Mar 22, 2023

Fixes #153430

Screen Shot 2023-03-22 at 9 13 57 AM

@nreese nreese mentioned this pull request Mar 22, 2023
Closed
nreese
nreese commented Mar 22, 2023
View reviewed changes
x-pack/plugins/maps/common/constants.ts

// Maplibre does not provide any feedback when rendering is complete.
// Workaround is hard-coded timeout period.
export const RENDER_TIMEOUT = 1000;
Copy link
Copy Markdown
Contributor Author

@nreese nreese Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced timeout from 5 seconds to 1 seconds because when timeout was first added, EMS basemap layers did not have great loading status. Now they do so this timeout seemed excessive.

nreese
nreese commented Mar 22, 2023
View reviewed changes
x-pack/plugins/maps/public/embeddable/map_component.tsx

if (this.props.onInitialRenderComplete) {
this._mapEmbeddable
.getOnRenderComplete$()
Copy link
Copy Markdown
Contributor Author

@nreese nreese Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced setOnInitialRenderComplete with getOnRenderComplete$ to provide a single solution that will work when maps is embeddabed in another embeddable (lens, legacy visualization tilemap, and legacy visualization regionmap).

@nreese nreese marked this pull request as ready for review March 22, 2023 23:54
@nreese nreese requested a review from a team as a code owner March 22, 2023 23:54
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// Feature:Maps v8.8.0 labels Mar 22, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 22, 2023

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2023

@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Mar 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested reporting with region map embeddable

x-pack/plugins/maps/public/embeddable/map_embeddable.tsx
const title = input.hidePanelTitles ? '' : input.title ?? savedMapTitle;
const savedObjectId = 'savedObjectId' in input ? input.savedObjectId : undefined;
this.updateOutput({
...this.getOutput(),
Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 27, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Alerting and Actions Telemetry "after all" hook in "Alerting and Actions Telemetry"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Alerting and Actions Telemetry "before all" hook in "Alerting and Actions Telemetry"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Alerts alerts "after all" hook in "alerts"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Alerts alerts "before all" hook in "alerts"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Alerts legacy alerts "after all" hook in "legacy alerts"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Alerts legacy alerts "before all" hook in "legacy alerts"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Connectors "after all" hook in "Connectors"
  • [job] [logs] FTR Configs #41 / alerting api integration security and spaces enabled - Group 2 Connectors "before all" hook in "Connectors"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 266 265 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +495.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 53.4KB 53.4KB +64.0B
Unknown metric groups

API count

id before after diff
maps 267 266 -1

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 35b5dd3 into elastic:main Mar 27, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Mar 27, 2023
@dej611 dej611 mentioned this pull request Mar 31, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Maps release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens][Maps] RegionMap chart type does not work with reporting

5 participants

@nreese @elasticmachine @kibana-ci @nickpeihl @kibanamachine