[8.7] [Fleet] Fix EPR and custom integration categories merge (#153221)#153225
Merged
kibanamachine merged 1 commit intoelastic:8.7from Mar 15, 2023
Merged
[8.7] [Fleet] Fix EPR and custom integration categories merge (#153221)#153225kibanamachine merged 1 commit intoelastic:8.7from
kibanamachine merged 1 commit intoelastic:8.7from
Conversation
## Summary While testing elastic/integrations#5123 and elastic#153216, I discovered two problems with the list of categories on the Browse integration page: 1. The categories list doesn't respect `showIntegrationsSubcategories` feature flag. When it is turned off, it will still only display top-level parent categories. This PR fixes that so that when `showIntegrationsSubcategories` is turned off, _all_ categories will be listed on the left sidebar. When it is turned on, only the top-level categories will be listed. 2. The merging of the categories list from EPR (i.e. `<EPR_HOST>/categories`) with the categories hard-coded in Kibana for custom integration cards is flawed: there can be a situation where a category or subcategory is not returned by EPR, due to no EPR-hosted integrations having it, but it is registered by a custom card. In this case, the category is missing from the list. This PR fixes the merging logic. (cherry picked from commit 340ee10)
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @jen-huang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.7:Questions ?
Please refer to the Backport tool documentation